Issue 5144049: Flexidate property demo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5144049: Flexidate property demo

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by RafeKap

Modified:
14 years, 3 months ago

Reviewers:
guido

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : More specific hack to serialize and deserialize flexidate #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -5 lines)			Patch
M	app.yaml	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	flexidate.py	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
A	flexidate_app.py	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
A	flexidate_property.py	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download
M	ndb/model.py	View	1	4 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

guido

14 years, 3 months ago (2011-09-28 01:21:01 UTC) #1

This sounds like a fine direction to go.

http://codereview.appspot.com/5144049/diff/1/flexidate_property.py
File flexidate_property.py (right):

http://codereview.appspot.com/5144049/diff/1/flexidate_property.py#newcode5
flexidate_property.py:5: class FlexidateProperty(model.StructuredProperty):
I think you want to derive from StructuredPropertyBase?

Expand All Messages | Collapse All Messages