Plug an ETW trace importer.

This CL adds a importer/parser for ETW events.

In the current state, there is no parsing/decoding of any events.
An abstract class "Parser" is provided and must be specialized for
each tracing facilities.


Event are produced by:
  https://codereview.chromium.org/171143002/

R=nduca@chromium.org

Committed: https://code.google.com/p/trace-viewer/source/detail?r=1161

[nduca, 2014-02-18 22:05:34]

lets thin this down so its just enough code to get the events out of the file
and run all the regisetered parsers. but, lets not add any parsers yet. so its
just the bare bones code to essentially iterate the trace and nothing else.

https://codereview.appspot.com/51300043/diff/40001/src/tracing/importer/etw_i...
File src/tracing/importer/etw_importer.js (right):

https://codereview.appspot.com/51300043/diff/40001/src/tracing/importer/etw_i...
src/tracing/importer/etw_importer.js:135: CpuState.prototype = {
lets remove this and all cpustate fields and add it in as a follwoup patch

https://codereview.appspot.com/51300043/diff/40001/src/tracing/importer/etw_i...
src/tracing/importer/etw_importer.js:204: var TestExports = {};
remove, not used

https://codereview.appspot.com/51300043/diff/40001/src/tracing/importer/etw_i...
src/tracing/importer/etw_importer.js:332: var decoder = new
Decoder(event.payload);
is there a way to not create a new decoder object for every event? this is going
to thrash gc pretty heavily

https://codereview.appspot.com/51300043/diff/40001/src/tracing/importer/etw_i...
src/tracing/importer/etw_importer.js:349: * Registers a windows ETW event parser
used by ????.
you need to go to the parser and ask it for all the regsitered types, and
construct them during the construction of this object. This will cause them to
call this register method.

[fdoray, 2014-02-19 16:17:36]

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw/...
File src/tracing/importer/etw/parser.js (right):

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw/...
src/tracing/importer/etw/parser.js:17: * Registers a subclass that will help
parse windows ETW events.
Registers a subclass that will help parse Windows ETW events.
                                          ^

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw/...
src/tracing/importer/etw/parser.js:18: * The importer will call createParsers
(below) before importing
createParsers() is not below but in etw_importer.js.

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw_...
File src/tracing/importer/etw_importer.js (right):

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw_...
src/tracing/importer/etw_importer.js:7: * trace format into theTracemodel. This
format is output by Chrome running
trace format into the Tracemodel.
                     ^

This format is outputted by Chrome
                     ^^^

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw_...
File src/tracing/importer/etw_importer_test.js (right):

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw_...
src/tracing/importer/etw_importer_test.js:13:
assertTrue(EtwImporter.canImport('dummy string'));
EtwImporter.canImport('dummy string') returns true? It doesn't have a 'name' or
'content' property.

[etienneb, 2014-02-19 22:32:47]

I did the minimal CL to accept the output of the Windows ETW tracing events from
Chrome.

For the Chrome implementation, see:
 https://codereview.chromium.org/171143002/

https://codereview.appspot.com/51300043/diff/40001/src/tracing/importer/etw_i...
File src/tracing/importer/etw_importer.js (right):

https://codereview.appspot.com/51300043/diff/40001/src/tracing/importer/etw_i...
src/tracing/importer/etw_importer.js:135: CpuState.prototype = {
On 2014/02/18 22:05:34, nduca wrote:
> lets remove this and all cpustate fields and add it in as a follwoup patch

Done.

https://codereview.appspot.com/51300043/diff/40001/src/tracing/importer/etw_i...
src/tracing/importer/etw_importer.js:204: var TestExports = {};
On 2014/02/18 22:05:34, nduca wrote:
> remove, not used

Done.

https://codereview.appspot.com/51300043/diff/40001/src/tracing/importer/etw_i...
src/tracing/importer/etw_importer.js:332: var decoder = new
Decoder(event.payload);
On 2014/02/18 22:05:34, nduca wrote:
> is there a way to not create a new decoder object for every event? this is
going
> to thrash gc pretty heavily

Done.

https://codereview.appspot.com/51300043/diff/40001/src/tracing/importer/etw_i...
src/tracing/importer/etw_importer.js:349: * Registers a windows ETW event parser
used by ????.
On 2014/02/18 22:05:34, nduca wrote:
> you need to go to the parser and ask it for all the regsitered types, and
> construct them during the construction of this object. This will cause them to
> call this register method.

Done.

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw/...
File src/tracing/importer/etw/parser.js (right):

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw/...
src/tracing/importer/etw/parser.js:17: * Registers a subclass that will help
parse windows ETW events.
On 2014/02/19 16:17:36, fdoray wrote:
> Registers a subclass that will help parse Windows ETW events.
>                                           ^

Done.

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw/...
src/tracing/importer/etw/parser.js:18: * The importer will call createParsers
(below) before importing
On 2014/02/19 16:17:36, fdoray wrote:
> createParsers() is not below but in etw_importer.js.

Done.

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw_...
File src/tracing/importer/etw_importer.js (right):

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw_...
src/tracing/importer/etw_importer.js:7: * trace format into theTracemodel. This
format is output by Chrome running
On 2014/02/19 16:17:36, fdoray wrote:
> trace format into the Tracemodel.
>                      ^
> 
> This format is outputted by Chrome
>                      ^^^

Done.

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw_...
File src/tracing/importer/etw_importer_test.js (right):

https://codereview.appspot.com/51300043/diff/100001/src/tracing/importer/etw_...
src/tracing/importer/etw_importer_test.js:13:
assertTrue(EtwImporter.canImport('dummy string'));
On 2014/02/19 16:17:36, fdoray wrote:
> EtwImporter.canImport('dummy string') returns true? It doesn't have a 'name'
or
> 'content' property.

Done.

[nduca, 2014-02-20 06:57:51]

lgtm

https://codereview.appspot.com/51300043/diff/140001/src/tracing/importer/etw_...
File src/tracing/importer/etw_importer.js (right):

https://codereview.appspot.com/51300043/diff/140001/src/tracing/importer/etw_...
src/tracing/importer/etw_importer.js:1: // Copyright (c) 2014 The Chromium
Authors. All rights reserved.
i think you want to modify importer/__init__.js to require etw_importer.js so
that this gets included in the tracing build

https://codereview.appspot.com/51300043/diff/140001/src/tracing/importer/etw_...
src/tracing/importer/etw_importer.js:55: this.payload_ = [];
payload_ = undefined;

[etienneb, 2014-02-20 15:36:21]

thanks, committing....

https://codereview.appspot.com/51300043/diff/140001/src/tracing/importer/etw_...
File src/tracing/importer/etw_importer.js (right):

https://codereview.appspot.com/51300043/diff/140001/src/tracing/importer/etw_...
src/tracing/importer/etw_importer.js:1: // Copyright (c) 2014 The Chromium
Authors. All rights reserved.
On 2014/02/20 06:57:52, nduca wrote:
> i think you want to modify importer/__init__.js to require etw_importer.js so
> that this gets included in the tracing build

Done.

https://codereview.appspot.com/51300043/diff/140001/src/tracing/importer/etw_...
src/tracing/importer/etw_importer.js:55: this.payload_ = [];
On 2014/02/20 06:57:52, nduca wrote:
> payload_ = undefined;

Done.

[etienneb, 2014-02-20 15:38:51]

Committed patchset #8 manually as r1161 (presubmit successful).