code review 5129042: exp/template/html: make sure marshalled JSON can be par...

exp/template/html: make sure marshalled JSON can be parsed as JS.

This makes sure that all JS newlines are encoded in JSON.

It also moots a TODO about possibly escaping supplemental codepoints.
I served:

Content-Type: text/javascript;charset=UTF-8

var s = "%s";
document.write("<p>", s, "</p><ol>");
for (var i = 0; i < s.length; i++) {
  document.write("<li>", s.charCodeAt(i).toString(16), "</li>");
}
document.write("</l>");

where %s was replaced with bytes "\xf0\x9d\x84\x9e" to test
straight UTF-8 instead of encoding surrogates separately.

Recent Firefox, Chrome, and Safari all decoded it properly.
I have yet to try it on IE or older versions.

[MikeSamuel, 2011-09-24 01:03:07]

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[nigeltao, 2011-09-25 09:25:35]

LGTM.

http://codereview.appspot.com/5129042/diff/3/src/pkg/exp/template/html/escape...
File src/pkg/exp/template/html/escape_test.go (right):

http://codereview.appspot.com/5129042/diff/3/src/pkg/exp/template/html/escape...
src/pkg/exp/template/html/escape_test.go:21: return []byte("{ foo: 'not quite
valid JSON' }"), nil
Add a comment that it's invalid JSON because "foo" is not quoted.

[MikeSamuel, 2011-09-26 09:10:18]

http://codereview.appspot.com/5129042/diff/3/src/pkg/exp/template/html/escape...
File src/pkg/exp/template/html/escape_test.go (right):

http://codereview.appspot.com/5129042/diff/3/src/pkg/exp/template/html/escape...
src/pkg/exp/template/html/escape_test.go:21: return []byte("{ foo: 'not quite
valid JSON' }"), nil
On 2011/09/25 09:25:35, nigeltao wrote:
> Add a comment that it's invalid JSON because "foo" is not quoted.

Done.

[MikeSamuel, 2011-09-26 09:10:47]

*** Submitted as http://code.google.com/p/go/source/detail?r=51f8e9c7cb59 ***

exp/template/html: make sure marshalled JSON can be parsed as JS.

This makes sure that all JS newlines are encoded in JSON.

It also moots a TODO about possibly escaping supplemental codepoints.
I served:

Content-Type: text/javascript;charset=UTF-8

var s = "%s";
document.write("<p>", s, "</p><ol>");
for (var i = 0; i < s.length; i++) {
  document.write("<li>", s.charCodeAt(i).toString(16), "</li>");
}
document.write("</l>");

where %s was replaced with bytes "\xf0\x9d\x84\x9e" to test
straight UTF-8 instead of encoding surrogates separately.

Recent Firefox, Chrome, and Safari all decoded it properly.
I have yet to try it on IE or older versions.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5129042