src/pkg/runtime/chan.c - Issue 5128053: code review 5128053: runtime: check for nil value pointer in select syncsend case

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/runtime/chan.c

Issue 5128053: code review 5128053: runtime: check for nil value pointer in select syncsend case (Closed)

Patch Set: diff -r 1f54df39aab7 https://go.googlecode.com/hg/ Created 13 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/runtime/chan.c

===================================================================

--- a/src/pkg/runtime/chan.c

+++ b/src/pkg/runtime/chan.c

@@ -1024,7 +1024,8 @@

selunlock(sel);

if(debug)

runtime·printf("syncsend: sel=%p c=%p o=%d\n", sel, c, o);

- c->elemalg->copy(c->elemsize, sg->elem, cas->sg.elem);

+ if(sg->elem != nil)

+ c->elemalg->copy(c->elemsize, sg->elem, cas->sg.elem);

gp = sg->g;

gp->param = sg;

runtime·ready(gp);

« no previous file with comments | « no previous file | test/chan/select7.go » ('j') | no next file with comments »