Issue 51280047: Remove existing Log handers when setupLogging.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 51280047: Remove existing Log handers when setupLogging.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by rharding

Modified:
10 years, 3 months ago

Reviewers:
frankban, mp+201453

Visibility:
Public.

Description

Remove existing Log handers when setupLogging. - If there are existing handlers on the root logger then the logging.basicConfig is a noop. Changes we expect to see will not occur. https://code.launchpad.net/~rharding/charms/precise/juju-gui/fix-log-test/+merge/201453 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	hooks/utils.py	View		1 chunk	+9 lines, -0 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

frankban

10 years, 3 months ago (2014-01-13 16:49:21 UTC) #2

LGTM with the suggested changes (especially the second one).
Thank you!

https://codereview.appspot.com/51280047/diff/1/hooks/utils.py
File hooks/utils.py (right):

https://codereview.appspot.com/51280047/diff/1/hooks/utils.py#newcode327
hooks/utils.py:327: if root_logger.handlers:
This check can be omitted.

https://codereview.appspot.com/51280047/diff/1/hooks/utils.py#newcode328
hooks/utils.py:328: for handler in root_logger.handlers:
I'd suggest to use:
for handler in root_logger.handlers[:]:
so that we avoid modifying in place the list we are looping over.

Expand All Messages | Collapse All Messages