Issue 5097046: code review 5097046: runtime: gdb support: gracefully handle not being able ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5097046: code review 5097046: runtime: gdb support: gracefully handle not being able ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by lvd

Modified:
13 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: gdb support: gracefully handle not being able to find types The Dwarf info has the full typenames, the go *struct runtime.commonType has the short name. A more permanent fix would link the two together but this way the user gets useable stack traces for now.

Patch Set 1 #

Patch Set 2 : diff -r b9195358cc18 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b9195358cc18 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 086dc976137c https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -4 lines)			Patch
	M	src/pkg/runtime/runtime-gdb.py	View	1	3 chunks	+27 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lvd

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-09-22 11:42:07 UTC) #1

rsc

LGTM I was just thinking we needed more Python in this project.

13 years, 5 months ago (2011-09-23 02:26:39 UTC) #2

lvd

13 years, 5 months ago (2011-09-23 08:28:05 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f2dcf06a2380 ***

runtime: gdb support: gracefully handle not being able to find types

The Dwarf info has the full typenames, the go *struct runtime.commonType
has the short name.  A more permanent fix would link the two together
but this way the user gets useable stack traces for now.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5097046

Expand All Messages | Collapse All Messages