Issue 5089045: Bug fixes to SES test, repair, and initialization

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5089045: Bug fixes to SES test, repair, and initialization (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by MarkM

Modified:
14 years, 6 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Bug fixes to SES test, repair, and initialization #

Patch Set 3 : Bug fixes to SES test, repair, and initialization #

Patch Set 4 : Bug fixes to SES test, repair, and initialization #

Patch Set 5 : Bug fixes to SES test, repair, and initialization #

Total comments: 4

Patch Set 6 : Bug fixes to SES test, repair, and initialization #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -46 lines)			Patch
M	src/com/google/caja/ses/repairES5.js	View	1 2 3 4 5	35 chunks	+97 lines, -44 lines	0 comments	Download
M	src/com/google/caja/ses/startSES.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/ses/useHTMLLogger.js	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ihab.awad

lgtm++ http://codereview.appspot.com/5089045/diff/9002/src/com/google/caja/ses/repairES5.js File src/com/google/caja/ses/repairES5.js (right): http://codereview.appspot.com/5089045/diff/9002/src/com/google/caja/ses/repairES5.js#newcode398 src/com/google/caja/ses/repairES5.js:398: that = ___global_valueOf_function___(); Why capture the retval? It's ...

14 years, 6 months ago (2011-09-28 04:45:07 UTC) #2

MarkM

14 years, 6 months ago (2011-09-28 11:08:02 UTC) #3

http://codereview.appspot.com/5089045/diff/9002/src/com/google/caja/ses/repai...
File src/com/google/caja/ses/repairES5.js (right):

http://codereview.appspot.com/5089045/diff/9002/src/com/google/caja/ses/repai...
src/com/google/caja/ses/repairES5.js:398: that =
___global_valueOf_function___();
On 2011/09/28 04:45:07, ihab.awad wrote:
> Why capture the retval? It's not used....

Thanks for catching this. I'm now testing it in two places I should have -- to
see if the thing that leaked is indeed the global, or if instead we're observing
a new symptom.

While I was looking at this, I also noticed two other such tests below that I
flipped to be more consistent with these.

Expand All Messages | Collapse All Messages