code review 5081044: syscall: add GetsockoptByte, SetsockoptByte for openbsd

syscall: add GetsockoptByte, SetsockoptByte for openbsd

[mikio, 2011-09-20 15:39:36]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[albert.strasheim, 2011-09-20 17:59:16]

http://codereview.appspot.com/5081044/diff/1004/src/pkg/syscall/syscall_bsd.go
File src/pkg/syscall/syscall_bsd.go (right):

http://codereview.appspot.com/5081044/diff/1004/src/pkg/syscall/syscall_bsd.g...
src/pkg/syscall/syscall_bsd.go:368: vallen := _Socklen(4)
Typo? vallen := _Socklen(1) maybe?

[mikio, 2011-09-20 22:12:36]

http://codereview.appspot.com/5081044/diff/1004/src/pkg/syscall/syscall_bsd.go
File src/pkg/syscall/syscall_bsd.go (right):

http://codereview.appspot.com/5081044/diff/1004/src/pkg/syscall/syscall_bsd.g...
src/pkg/syscall/syscall_bsd.go:368: vallen := _Socklen(4)
On 2011/09/20 17:59:16, albert.strasheim wrote:
> Typo? vallen := _Socklen(1) maybe?

oops, thx.

http://codereview.appspot.com/5081044/diff/1004/src/pkg/syscall/syscall_bsd.g...
src/pkg/syscall/syscall_bsd.go:368: vallen := _Socklen(4)
On 2011/09/20 17:59:16, albert.strasheim wrote:
> Typo? vallen := _Socklen(1) maybe?

Done.

[mikio, 2011-09-20 22:13:03]

Hello golang-dev@googlegroups.com, fullung@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2011-09-21 10:07:18]

LGTM

http://codereview.appspot.com/5081044/diff/8001/src/pkg/syscall/syscall_bsd.go
File src/pkg/syscall/syscall_bsd.go (right):

http://codereview.appspot.com/5081044/diff/8001/src/pkg/syscall/syscall_bsd.g...
src/pkg/syscall/syscall_bsd.go:370: return byte(n), errno
n is already of type byte, do you need to repeat the cast here ?

[mikio, 2011-09-21 10:17:56]

http://codereview.appspot.com/5081044/diff/8001/src/pkg/syscall/syscall_bsd.go
File src/pkg/syscall/syscall_bsd.go (right):

http://codereview.appspot.com/5081044/diff/8001/src/pkg/syscall/syscall_bsd.g...
src/pkg/syscall/syscall_bsd.go:370: return byte(n), errno
On 2011/09/21 10:07:18, dfc wrote:
> n is already of type byte, do you need to repeat the cast here ?

only four lines but I was blind. how could it be? thx.
Done.

[mikio, 2011-09-21 10:18:18]

Hello golang-dev@googlegroups.com, fullung@gmail.com, dave@cheney.net (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-09-23 01:59:42]

LGTM

[mikio, 2011-09-23 14:39:22]

*** Submitted as http://code.google.com/p/go/source/detail?r=ea8bbc8212d6 ***

syscall: add GetsockoptByte, SetsockoptByte for openbsd

R=golang-dev, fullung, dave, rsc
CC=golang-dev
http://codereview.appspot.com/5081044