Issue 5077042: Fix dconf profile installation.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5077042: Fix dconf profile installation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by Daiki Ueno

Modified:
14 years, 6 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Fix dconf profile installation. BUG=none TEST=manual

Patch Set 1 #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	data/dconf/Makefile.am	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Daiki Ueno

Sorry, my review comment was wrong: https://codereview.appspot.com/4994043/ It seems that both nobase_dconfprofile_DATA and nobase_dist_dconfprofile_DATA cannot ...

14 years, 6 months ago (2011-09-20 08:32:19 UTC) #1

Peng

On 2011/09/20 08:32:19, Daiki Ueno wrote: > Sorry, my review comment was wrong: > https://codereview.appspot.com/4994043/ ...

14 years, 6 months ago (2011-09-20 15:36:10 UTC) #2

Peng

14 years, 6 months ago (2011-09-20 16:05:41 UTC) #3

On 2011/09/20 15:36:10, Peng wrote:
> On 2011/09/20 08:32:19, Daiki Ueno wrote:
> > Sorry, my review comment was wrong:
> > https://codereview.appspot.com/4994043/
> > 
> > It seems that both nobase_dconfprofile_DATA and
nobase_dist_dconfprofile_DATA
> > cannot be specified at the same time.
> > 
> > This patch fixes this.
> 
> Did you try make distcheck on a machine without dconf?

LGTM. I tested it.

Expand All Messages | Collapse All Messages