code review 5071044: testing: Add support for running tests in parallel (t.P...

src/pkg/testing/testing.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // Package testing provides support for automated testing of Go packages.
 // It is intended to be used in concert with the ``gotest'' utility, which automates
 // execution of any function of the form
 //     func TestXxx(*testing.T)
 // where Xxx can be any alphanumeric string (but the first letter must not be in
 // [a-z]) and serves to identify the test routine.
@@ skipping 219 matching lines @@
                         out := <-t.ch
                         if out == nil { // Parallel run.
                                 numParallel++
                                 continue
                         }
                         report(t)
                         ok = ok && !out.failed
                 }
 
                 running := 0
-                for numParallel + running > 0 {
+                for numParallel+running > 0 {
                         if running < *parallel && numParallel > 0 {
                                 startParallel <- true
                                 running++
-                                numParallel --

[r, 2011/10/06 03:33:31]

did this run through gofmt? there's a space before the --
please fix.

[tebeka, 2011/10/06 16:49:11]

Done.

+                                numParallel--
                                 continue
                         }
                         t := <-ch
                         report(t)
                         ok = ok && !t.failed
                         running--
                 }
         }
 
         if !ok {
@@ skipping 70 matching lines @@
                 for _, val := range strings.Split(*cpuListStr, ",") {
                         cpu, err := strconv.Atoi(val)
                         if err != nil || cpu <= 0 {
                                 println("invalid value for -test.cpu")
                                 os.Exit(1)
                         }
                         cpuList = append(cpuList, cpu)
                 }
         }
 }