code review 5043046: vim: Send GoFmt errors to a location list

vim: Send GoFmt errors to a location list

[tones111, 2011-09-18 04:00:49]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[tones111, 2011-09-18 04:07:57]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2011-09-18 22:53:24]

Please fill out the copyright stuff, as documented here:
  http://golang.org/doc/contribute.html#copyright

http://codereview.appspot.com/5043046/diff/7001/misc/vim/ftplugin/go/fmt.vim
File misc/vim/ftplugin/go/fmt.vim (right):

http://codereview.appspot.com/5043046/diff/7001/misc/vim/ftplugin/go/fmt.vim#...
misc/vim/ftplugin/go/fmt.vim:24: let tokens = matchlist(line,
'^\(.\{-}\):\(\d\+\):\(\d\+\)\s*\(.*\)')
you should check for matchlist failing. This should gracefully fail if, for
instance, gofmt changes its output format.

[tones111, 2011-09-22 02:22:21]

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2011-09-22 03:04:27]

LGTM

[dsymonds, 2011-09-22 03:09:09]

Actually, are you sure this works? I've patched it over, and running :Fmt gives
me the error message, but doesn't set any locations (e.g. :cn doesn't do
anything).

[sbarra.paul_gmail.com, 2011-09-22 22:29:27]

On Wed, Sep 21, 2011 at 10:09 PM, <dsymonds@golang.org> wrote:

> Actually, are you sure this works? I've patched it over, and running
> :Fmt gives me the error message, but doesn't set any locations (e.g. :cn
> doesn't do anything).
>
>
>
http://codereview.appspot.com/**5043046/<http://codereview.appspot.com/5043046/>
>


I believe you're seeing the desired behavior (I admit I'm new at working
with Vim).  Location lists are separate from the quickfix window.  Instead
of one shared quickfix window for the Vim instance you can have a location
list for each buffer.  I think this is a better fit for gofmt since only one
file is processed at a time.  The commands for location list are very
similar to quickfix, but most are prefixed with an l instead of c.  For
example, lprevious and lnext will let you transition through the list
elements.  lopen / lclose to open and close the list.  See
http://vimdoc.sourceforge.net/htmldoc/quickfix.html#quickfix for other
commands.

Thanks for taking the time to review this change!  Let me know if there are
any other functional tweaks needed / desired.

[dsymonds, 2011-09-22 23:38:08]

LGTM

Aah, gotcha.

[dsymonds, 2011-09-22 23:38:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=d7460049e3bf ***

vim: Send GoFmt errors to a location list

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5043046

Committer: David Symonds <dsymonds@golang.org>