Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(358)

Issue 5040042: code review 5040042: weekly.2011-09-16 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by adg
Modified:
11 years, 2 months ago
Reviewers:
CC:
golang-dev, dsymonds, r2
Visibility:
Public.

Description

weekly.2011-09-16

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r b80728111ff9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b80728111ff9 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ec084c7a70c9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M .hgtags View 1 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 7
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 2 months ago (2011-09-16 00:39:04 UTC) #1
dsymonds
LGTM http://codereview.appspot.com/5040042/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5040042/diff/1/doc/devel/weekly.html#newcode62 doc/devel/weekly.html:62: * json: if a field's tag is "-", ...
11 years, 2 months ago (2011-09-16 00:48:20 UTC) #2
adg
Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 2 months ago (2011-09-16 00:51:54 UTC) #3
dsymonds
LGTM
11 years, 2 months ago (2011-09-16 00:56:33 UTC) #4
r2
There's no gofix for either API change but instances of the old API will be ...
11 years, 2 months ago (2011-09-16 05:26:36 UTC) #5
adg
Hello golang-dev@googlegroups.com, dsymonds@golang.org, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 2 months ago (2011-09-16 06:15:24 UTC) #6
adg
11 years, 2 months ago (2011-09-16 07:18:43 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=8a09ce0cefc6 ***

weekly.2011-09-16

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/5040042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b