Issue 5034044: code review 5034044: net: make use of AF_UNSPEC instead of individual addres...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5034044: code review 5034044: net: make use of AF_UNSPEC instead of individual addres... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by mikio

Modified:
13 years, 5 months ago

Reviewers:

CC:
albert.strasheim, rsc, golang-dev

Visibility:
Public.

Description

net: make use of AF_UNSPEC instead of individual address family

Patch Set 1 : diff -r 5381c9668045 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r ec084c7a70c9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a33d941e6c51 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f2dcf06a2380 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -25 lines)			Patch
	M	src/pkg/net/interface_bsd.go	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/pkg/net/interface_linux.go	View		1 chunk	+11 lines, -24 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

albert.strasheim

LGTM. Fixes an issue where I was seeing duplicate IPv4 addresses on a F16 machine ...

13 years, 6 months ago (2011-09-16 07:47:13 UTC) #1

mikio

Hello golang-dev@googlegroups.com, fullung@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2011-09-16 08:14:35 UTC) #2

mikio

13 years, 5 months ago (2011-09-23 14:37:45 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=e2087f36b029 ***

net: make use of AF_UNSPEC instead of individual address family

R=fullung, rsc
CC=golang-dev
http://codereview.appspot.com/5034044

Expand All Messages | Collapse All Messages