Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(344)

Issue 5021044: Weight Paint (Radish Branch 2011)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by ideasman42
Modified:
10 years, 4 months ago
Reviewers:
mattebb, bf-codereview, nazgul, jason.hays22
CC:
ideasman42
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Patch Set 1 #

Total comments: 49
Unified diffs Side-by-side diffs Delta from patch set Stats (+1901 lines, -82 lines) Patch
M release/scripts/startup/bl_ui/properties_data_mesh.py View 1 chunk +4 lines, -0 lines 0 comments Download
M release/scripts/startup/bl_ui/space_view3d.py View 1 chunk +2 lines, -0 lines 0 comments Download
M release/scripts/startup/bl_ui/space_view3d_toolbar.py View 2 chunks +3 lines, -0 lines 0 comments Download
M source/blender/blenkernel/BKE_DerivedMesh.h View 1 chunk +3 lines, -0 lines 3 comments Download
M source/blender/blenkernel/BKE_armature.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/blender/blenkernel/BKE_paint.h View 1 chunk +2 lines, -1 line 0 comments Download
M source/blender/blenkernel/intern/DerivedMesh.c View 9 chunks +75 lines, -17 lines 2 comments Download
M source/blender/blenkernel/intern/armature.c View 1 chunk +29 lines, -0 lines 0 comments Download
M source/blender/blenkernel/intern/cdderivedmesh.c View 2 chunks +40 lines, -0 lines 1 comment Download
M source/blender/blenkernel/intern/paint.c View 1 chunk +5 lines, -1 line 0 comments Download
M source/blender/editors/armature/editarmature.c View 3 chunks +58 lines, -8 lines 2 comments Download
M source/blender/editors/armature/meshlaplacian.c View 1 chunk +11 lines, -7 lines 0 comments Download
M source/blender/editors/include/ED_mesh.h View 1 chunk +3 lines, -1 line 0 comments Download
M source/blender/editors/include/ED_view3d.h View 2 chunks +4 lines, -0 lines 0 comments Download
M source/blender/editors/interface/interface_templates.c View 1 chunk +13 lines, -0 lines 0 comments Download
M source/blender/editors/mesh/editmesh.c View 1 chunk +93 lines, -0 lines 2 comments Download
M source/blender/editors/mesh/editmesh_mods.c View 2 chunks +2 lines, -0 lines 0 comments Download
M source/blender/editors/object/object_intern.h View 1 chunk +4 lines, -0 lines 0 comments Download
M source/blender/editors/object/object_ops.c View 1 chunk +4 lines, -0 lines 0 comments Download
M source/blender/editors/object/object_vgroup.c View 16 chunks +576 lines, -1 line 22 comments Download
M source/blender/editors/sculpt_paint/paint_image.c View 1 chunk +10 lines, -1 line 0 comments Download
M source/blender/editors/sculpt_paint/paint_intern.h View 1 chunk +4 lines, -0 lines 0 comments Download
M source/blender/editors/sculpt_paint/paint_ops.c View 2 chunks +13 lines, -0 lines 2 comments Download
M source/blender/editors/sculpt_paint/paint_utils.c View 1 chunk +24 lines, -0 lines 0 comments Download
M source/blender/editors/sculpt_paint/paint_vertex.c View 19 chunks +560 lines, -33 lines 4 comments Download
M source/blender/editors/space_view3d/drawmesh.c View 1 chunk +1 line, -1 line 0 comments Download
M source/blender/editors/space_view3d/drawobject.c View 5 chunks +94 lines, -2 lines 2 comments Download
M source/blender/editors/space_view3d/space_view3d.c View 1 chunk +4 lines, -0 lines 0 comments Download
M source/blender/editors/space_view3d/view3d_header.c View 1 chunk +8 lines, -1 line 0 comments Download
M source/blender/editors/space_view3d/view3d_select.c View 11 chunks +189 lines, -4 lines 3 comments Download
M source/blender/makesdna/DNA_mesh_types.h View 1 chunk +1 line, -1 line 0 comments Download
M source/blender/makesdna/DNA_object_types.h View 1 chunk +5 lines, -0 lines 0 comments Download
M source/blender/makesdna/DNA_scene_types.h View 1 chunk +5 lines, -2 lines 0 comments Download
M source/blender/makesrna/intern/rna_internal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M source/blender/makesrna/intern/rna_mesh.c View 2 chunks +25 lines, -1 line 0 comments Download
M source/blender/makesrna/intern/rna_object.c View 2 chunks +15 lines, -0 lines 4 comments Download
M source/blender/makesrna/intern/rna_scene.c View 1 chunk +8 lines, -0 lines 2 comments Download

Messages

Total messages: 12
ideasman42
Some issues from my review raised a few issues.. - Should pose bone select behavior ...
10 years, 4 months ago (2011-09-15 03:00:08 UTC) #1
mattebb
http://codereview.appspot.com/5021044/diff/1/source/blender/makesrna/intern/rna_scene.c File source/blender/makesrna/intern/rna_scene.c (right): http://codereview.appspot.com/5021044/diff/1/source/blender/makesrna/intern/rna_scene.c#newcode1123 source/blender/makesrna/intern/rna_scene.c:1123: RNA_def_property_update(prop, 0, "rna_update_active_object"); This doesn't look right - especially ...
10 years, 4 months ago (2011-09-15 06:49:12 UTC) #2
ideasman42
reply to matt's comment. http://codereview.appspot.com/5021044/diff/1/source/blender/makesrna/intern/rna_scene.c File source/blender/makesrna/intern/rna_scene.c (right): http://codereview.appspot.com/5021044/diff/1/source/blender/makesrna/intern/rna_scene.c#newcode1123 source/blender/makesrna/intern/rna_scene.c:1123: RNA_def_property_update(prop, 0, "rna_update_active_object"); On 2011/09/15 ...
10 years, 4 months ago (2011-09-15 07:07:43 UTC) #3
nazgul
Made some review. Some general notes (which aren't actually stoppers and can be made after ...
10 years, 4 months ago (2011-09-15 07:57:10 UTC) #4
ideasman42
Reply to nazgul's comments. http://codereview.appspot.com/5021044/diff/1/source/blender/blenkernel/BKE_DerivedMesh.h File source/blender/blenkernel/BKE_DerivedMesh.h (right): http://codereview.appspot.com/5021044/diff/1/source/blender/blenkernel/BKE_DerivedMesh.h#newcode226 source/blender/blenkernel/BKE_DerivedMesh.h:226: void (*drawSelectedVerts)(DerivedMesh *dm); On 2011/09/15 ...
10 years, 4 months ago (2011-09-15 12:43:04 UTC) #5
jason.hays22
http://codereview.appspot.com/5021044/diff/1/source/blender/makesrna/intern/rna_object.c File source/blender/makesrna/intern/rna_object.c (right): http://codereview.appspot.com/5021044/diff/1/source/blender/makesrna/intern/rna_object.c#newcode224 source/blender/makesrna/intern/rna_object.c:224: void rna_update_active_object(Main *bmain, Scene *scene, PointerRNA *ptr) On 2011/09/15 ...
10 years, 4 months ago (2011-09-17 19:17:37 UTC) #6
jason.hays22
http://codereview.appspot.com/5021044/diff/1/source/blender/editors/mesh/editmesh.c File source/blender/editors/mesh/editmesh.c (right): http://codereview.appspot.com/5021044/diff/1/source/blender/editors/mesh/editmesh.c#newcode1996 source/blender/editors/mesh/editmesh.c:1996: void paintvert_deselect_all_visible(Object *ob, int action, short flush_flags) The optional ...
10 years, 4 months ago (2011-09-17 19:26:51 UTC) #7
jason.hays22
http://codereview.appspot.com/5021044/diff/1/source/blender/editors/space_view3d/view3d_select.c File source/blender/editors/space_view3d/view3d_select.c (right): http://codereview.appspot.com/5021044/diff/1/source/blender/editors/space_view3d/view3d_select.c#newcode206 source/blender/editors/space_view3d/view3d_select.c:206: static void EM_backbuf_checkAndSelectTVerts(Mesh *me, int select) On 2011/09/15 03:00:08, ...
10 years, 4 months ago (2011-09-17 22:48:38 UTC) #8
jason.hays22
I also added hidden verts support to a function in drawobject.c--I forgot that in the ...
10 years, 4 months ago (2011-09-18 01:14:46 UTC) #9
ideasman42
http://codereview.appspot.com/5021044/diff/1/source/blender/editors/space_view3d/view3d_select.c File source/blender/editors/space_view3d/view3d_select.c (right): http://codereview.appspot.com/5021044/diff/1/source/blender/editors/space_view3d/view3d_select.c#newcode206 source/blender/editors/space_view3d/view3d_select.c:206: static void EM_backbuf_checkAndSelectTVerts(Mesh *me, int select) On 2011/09/17 22:48:38, ...
10 years, 4 months ago (2011-09-18 03:28:21 UTC) #10
jason.hays22
On 2011/09/18 03:28:21, ideasman42 wrote: > http://codereview.appspot.com/5021044/diff/1/source/blender/editors/space_view3d/view3d_select.c > File source/blender/editors/space_view3d/view3d_select.c (right): > > http://codereview.appspot.com/5021044/diff/1/source/blender/editors/space_view3d/view3d_select.c#newcode206 > ...
10 years, 4 months ago (2011-09-18 03:41:30 UTC) #11
nazgul
10 years, 4 months ago (2011-09-18 08:59:50 UTC) #12
http://codereview.appspot.com/5021044/diff/1/source/blender/editors/object/ob...
File source/blender/editors/object/object_vgroup.c (right):

http://codereview.appspot.com/5021044/diff/1/source/blender/editors/object/ob...
source/blender/editors/object/object_vgroup.c:789: static int*
getSurroundingVerts(Mesh *me, int vert, int *count) {
On 2011/09/18 01:14:46, jason.hays22 wrote:
> On 2011/09/15 07:57:10, nazgul wrote:
> > Looks like count wouldn't be set in several cases (if found is zero to the
end
> > of this funciton)
> 
> How?  Unless it is a single point in space, it'll have vertices surrounding
it..
>  Do you have an example?

Well, for example mesh as point cloud. Not sure it's really issue. That message
was just more like a warning which better be checked -- depends on how result of
function is used.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b