Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 5018044: code review 5018044: go/build: handle cgo, //build comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by rsc
Modified:
9 years, 2 months ago
Reviewers:
CC:
adg, golang-dev
Visibility:
Public.

Description

go/build: handle cgo, //build comments

Patch Set 1 #

Patch Set 2 : diff -r db14453eda18 https://go.googlecode.com/hg #

Patch Set 3 : diff -r db14453eda18 https://go.googlecode.com/hg #

Total comments: 9

Patch Set 4 : diff -r 2a7e3e5d18bd https://go.googlecode.com/hg #

Patch Set 5 : diff -r 2a7e3e5d18bd https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -68 lines) Patch
M src/cmd/goinstall/main.go View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M src/cmd/goinstall/make.go View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/gotest/gotest.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/build/build_test.go View 1 4 chunks +17 lines, -8 lines 0 comments Download
M src/pkg/go/build/cgotest/cgotest.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/go/build/dir.go View 1 2 3 4 9 chunks +344 lines, -48 lines 0 comments Download
M src/pkg/go/build/syslist_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
9 years, 2 months ago (2011-09-14 17:31:28 UTC) #1
adg
LGTM http://codereview.appspot.com/5018044/diff/5001/src/cmd/goinstall/main.go File src/cmd/goinstall/main.go (right): http://codereview.appspot.com/5018044/diff/5001/src/cmd/goinstall/main.go#newcode240 src/cmd/goinstall/main.go:240: terrorf(tree, "%s: found package %s in %s, want ...
9 years, 2 months ago (2011-09-15 01:07:05 UTC) #2
rsc
Comments now, fixes in the morning. http://codereview.appspot.com/5018044/diff/5001/src/cmd/goinstall/main.go File src/cmd/goinstall/main.go (right): http://codereview.appspot.com/5018044/diff/5001/src/cmd/goinstall/main.go#newcode240 src/cmd/goinstall/main.go:240: terrorf(tree, "%s: found ...
9 years, 2 months ago (2011-09-15 01:31:11 UTC) #3
rsc
9 years, 2 months ago (2011-09-15 16:11:46 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=e292d4870573 ***

go/build: handle cgo, //build comments

R=adg
CC=golang-dev
http://codereview.appspot.com/5018044

http://codereview.appspot.com/5018044/diff/5001/src/pkg/go/build/dir.go
File src/pkg/go/build/dir.go (right):

http://codereview.appspot.com/5018044/diff/5001/src/pkg/go/build/dir.go#newco...
src/pkg/go/build/dir.go:194: for _, com := range pf.Comments {
On 2011/09/15 01:07:05, adg wrote:
> Maybe put this in a function? It's really only asking one question.

Done.

http://codereview.appspot.com/5018044/diff/5001/src/pkg/go/build/dir.go#newco...
src/pkg/go/build/dir.go:234: isCgo := false
On 2011/09/15 01:07:05, adg wrote:
> again, a function?

Not as obvious.  This is recording the imports as well 
as figuring out whether cgo is in use.  I'd rather leave it
as is.  I added an overview comment.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b