Issue 4996048: code review 4996048: net: add a LookupTXT function.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4996048: code review 4996048: net: add a LookupTXT function. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by nigeltao

Modified:
13 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

net: add a LookupTXT function. This CL only supports Unix, not Plan 9 or Windows.

Patch Set 1 #

Patch Set 2 : diff -r 7c5022f761af https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7c5022f761af https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 11e69ba5ea31 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 11e69ba5ea31 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 902201d20e3a https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -4 lines)			Patch
M	src/pkg/net/lookup_plan9.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/net/lookup_test.go	View	1 2 3 4	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/pkg/net/lookup_unix.go	View	1	1 chunk	+17 lines, -4 lines	0 comments	Download
M	src/pkg/net/lookup_windows.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-09-12 04:17:45 UTC) #1

rsc

Please add a test. It shouldn't run by default but look at TestGmailMX for an ...

13 years, 7 months ago (2011-09-12 17:06:42 UTC) #3

nigeltao

On 13 September 2011 03:06, Russ Cox <rsc@golang.org> wrote: > Please add a test. It ...

13 years, 7 months ago (2011-09-12 22:50:40 UTC) #4

nigeltao

13 years, 7 months ago (2011-09-13 03:05:39 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=2302c9faa3ff ***

net: add a LookupTXT function.

This CL only supports Unix, not Plan 9 or Windows.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4996048

Expand All Messages | Collapse All Messages