Issue 4994043: Fix make dist error if dsettings does not exist.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4994043: Fix make dist error if dsettings does not exist. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by Peng

Modified:
14 years, 6 months ago

Reviewers:
Daiki Ueno

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Fix make dist error if dsettings does not exist. BUG=make dist failed without gsettings TEST=make dist

Patch Set 2 : update #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	data/dconf/Makefile.am	View	1	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Daiki Ueno

https://codereview.appspot.com/4994043/diff/1/data/dconf/Makefile.am File data/dconf/Makefile.am (right): https://codereview.appspot.com/4994043/diff/1/data/dconf/Makefile.am#newcode45 data/dconf/Makefile.am:45: nodist_dconfprofile_DATA = \ s/nodist/nobase/ ? nobase is necessary to ...

14 years, 6 months ago (2011-09-09 01:22:20 UTC) #2

Peng

Updated patch. Please check it again. https://codereview.appspot.com/4994043/diff/1/data/dconf/Makefile.am File data/dconf/Makefile.am (right): https://codereview.appspot.com/4994043/diff/1/data/dconf/Makefile.am#newcode45 data/dconf/Makefile.am:45: nodist_dconfprofile_DATA = \ ...

14 years, 6 months ago (2011-09-09 02:24:39 UTC) #3

LGTM, thanks.

Expand All Messages | Collapse All Messages