Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(867)

Issue 4981047: code review 4981047: doc: release.r60 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by adg
Modified:
11 years, 3 months ago
Reviewers:
CC:
dsymonds, r, rsc, golang-dev
Visibility:
Public.

Description

doc: release.r60

Patch Set 1 #

Total comments: 9

Patch Set 2 : diff -r ef81a396f9ae https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7050960923e0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7050960923e0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -2 lines) Patch
M doc/devel/release.html View 1 2 chunks +76 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 3 months ago (2011-09-07 03:36:04 UTC) #1
dsymonds
LGTM
11 years, 3 months ago (2011-09-07 03:39:18 UTC) #2
r
LGTM
11 years, 3 months ago (2011-09-07 18:16:01 UTC) #3
rsc
http://codereview.appspot.com/4981047/diff/1/doc/devel/release.html File doc/devel/release.html (right): http://codereview.appspot.com/4981047/diff/1/doc/devel/release.html#newcode33 doc/devel/release.html:33: is another "if". Since gofmt always puts those braces ...
11 years, 3 months ago (2011-09-07 18:39:57 UTC) #4
adg
PTAL http://codereview.appspot.com/4981047/diff/1/doc/devel/release.html File doc/devel/release.html (right): http://codereview.appspot.com/4981047/diff/1/doc/devel/release.html#newcode33 doc/devel/release.html:33: is another "if". Since gofmt always puts those ...
11 years, 3 months ago (2011-09-07 22:34:27 UTC) #5
adg
Hello golang-dev@googlegroups.com, dsymonds@golang.org, r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 3 months ago (2011-09-08 01:16:36 UTC) #6
rsc
LGTM
11 years, 3 months ago (2011-09-08 01:59:51 UTC) #7
adg
11 years, 3 months ago (2011-09-08 02:08:15 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=c0fea223bc90 ***

doc: release.r60

R=dsymonds, r, rsc
CC=golang-dev
http://codereview.appspot.com/4981047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b