Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1688)

Issue 4975046: code review 4975046: weekly.2011-09-01 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by nigeltao
Modified:
9 years, 6 months ago
Reviewers:
CC:
r, adg, golang-dev
Visibility:
Public.

Description

weekly.2011-09-01

Patch Set 1 #

Patch Set 2 : diff -r 68c83c6fed16 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 68c83c6fed16 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 68c83c6fed16 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 68c83c6fed16 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -1 line) Patch
M .hgtags View 1 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 3 1 chunk +146 lines, -0 lines 0 comments Download

Messages

Total messages: 6
nigeltao
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 6 months ago (2011-09-01 06:44:51 UTC) #1
adg
LGTM http://codereview.appspot.com/4975046/diff/4001/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/4975046/diff/4001/doc/devel/weekly.html#newcode22 doc/devel/weekly.html:22: The gc compiler now does escape analysis, which ...
9 years, 6 months ago (2011-09-01 06:55:32 UTC) #2
r
http://codereview.appspot.com/4975046/diff/4001/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/4975046/diff/4001/doc/devel/weekly.html#newcode24 doc/devel/weekly.html:24: Despite the long list of changes, there are no ...
9 years, 6 months ago (2011-09-01 06:58:21 UTC) #3
nigeltao
On 1 September 2011 16:58, <r@golang.org> wrote: > you don't say anything about container/vector PTAL.
9 years, 6 months ago (2011-09-01 07:05:26 UTC) #4
r
LGTM
9 years, 6 months ago (2011-09-01 07:07:07 UTC) #5
nigeltao
9 years, 6 months ago (2011-09-01 07:09:03 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=c934f6f5fe8b ***

weekly.2011-09-01

R=r, adg
CC=golang-dev
http://codereview.appspot.com/4975046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b