Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 4973057: code review 4973057: gc: unify stack frame layout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by rsc
Modified:
13 years, 7 months ago
Reviewers:
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: unify stack frame layout allocparams + tempname + compactframe all knew about how to place stack variables. Now only compactframe, renamed to allocauto, does the work. Until the last minute, each PAUTO variable is in its own space and has xoffset == 0. This might break 5g. I get failures in concurrent code running under qemu and I can't tell whether it's 5g's fault or qemu's. We'll see what the real ARM builders say.

Patch Set 1 #

Patch Set 2 : diff -r 1cd42fb11eea https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2a748f320ba5 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -137 lines) Patch
M src/cmd/5g/gsubr.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/5g/reg.c View 1 8 chunks +14 lines, -14 lines 0 comments Download
M src/cmd/6g/gsubr.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/6g/reg.c View 1 8 chunks +15 lines, -20 lines 0 comments Download
M src/cmd/8g/gsubr.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/8g/reg.c View 1 9 chunks +15 lines, -15 lines 0 comments Download
M src/cmd/gc/bits.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/gc/dcl.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/gen.c View 1 2 6 chunks +9 lines, -69 lines 0 comments Download
M src/cmd/gc/go.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M src/cmd/gc/pgen.c View 1 5 chunks +6 lines, -7 lines 0 comments Download
M src/cmd/gc/subr.c View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
13 years, 7 months ago (2011-09-06 14:24:21 UTC) #1
rsc
13 years, 7 months ago (2011-09-06 14:24:27 UTC) #2
*** Submitted as http://code.google.com/p/go/source/detail?r=ce2e5f44b310 ***

gc: unify stack frame layout

allocparams + tempname + compactframe
all knew about how to place stack variables.

Now only compactframe, renamed to allocauto,
does the work.  Until the last minute, each PAUTO
variable is in its own space and has xoffset == 0.

This might break 5g.  I get failures in concurrent
code running under qemu and I can't tell whether
it's 5g's fault or qemu's.  We'll see what the real
ARM builders say.

R=ken2
CC=golang-dev
http://codereview.appspot.com/4973057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b