Issue 4972051: code review 4972051: runtime: handle string + char literals in goc2c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4972051: code review 4972051: runtime: handle string + char literals in goc2c (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by rsc

Modified:
13 years, 10 months ago

Reviewers:

CC:
iant, golang-dev

Visibility:
Public.

Description

runtime: handle string + char literals in goc2c My string literal was being rewritten from "runtime.SysReserve(%p, %D) = error %d" to "runtime.SysReserve ( %p , %D ) = error %d"

Patch Set 2 : diff -r 9ec6df7522b3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9ec6df7522b3 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 5df28113c0d1 https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
	M	src/pkg/runtime/goc2c.c	View	1 2 3	2 chunks	+24 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-08-31 03:04:10 UTC) #1

iant

LGTM http://codereview.appspot.com/4972051/diff/3/src/pkg/runtime/goc2c.c File src/pkg/runtime/goc2c.c (right): http://codereview.appspot.com/4972051/diff/3/src/pkg/runtime/goc2c.c#newcode199 src/pkg/runtime/goc2c.c:199: * Read and return a token. Tokens are ...

13 years, 10 months ago (2011-08-31 05:30:59 UTC) #2

rsc

13 years, 10 months ago (2011-08-31 11:11:47 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=acb2a592d642 ***

runtime: handle string + char literals in goc2c

My string literal was being rewritten from
"runtime.SysReserve(%p, %D) = error %d"
to
"runtime.SysReserve ( %p , %D ) = error %d"

R=iant
CC=golang-dev
http://codereview.appspot.com/4972051

Expand All Messages | Collapse All Messages