Issue 49660043: Implement sampling profiler (trace-viewer/about_tracing part)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49660043: Implement sampling profiler (trace-viewer/about_tracing part) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by haraken

Modified:
11 years, 5 months ago

Reviewers:
dsinclair, nduca, Xianzhu

CC:
trace-viewer-review_googlegroups.com

Base URL:
http://trace-viewer.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Implement sampling profiler (trace-viewer/about_tracing part) Chromium side change is here: https://codereview.chromium.org/109933006/ Screenshot of the profiler: http://haraken.info/null/sampling_tracing.png Design document: https://docs.google.com/a/google.com/document/d/1j39sbA9ECTwFFlxbhSD1EvJnGfYeS5EUJ05yxuku6VY/edit R=nduca@chromium.org Committed: https://code.google.com/p/trace-viewer/source/detail?r=1087

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+295 lines, -255 lines)			Patch
D	src/about_tracing/begin_recording.js	View	1 chunk	+0 lines, -173 lines	0 comments	Download
D	src/about_tracing/begin_recording_test.js	View	1 chunk	+0 lines, -58 lines	0 comments	Download
M	src/about_tracing/mock_request_handler.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/about_tracing/profiling_view.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/about_tracing/profiling_view.js	View	5 chunks	+107 lines, -6 lines	0 comments	Download
M	src/about_tracing/profiling_view_test.js	View	3 chunks	+49 lines, -2 lines	0 comments	Download
A +	src/about_tracing/tracing_ui_client.js	View	8 chunks	+83 lines, -11 lines	0 comments	Download
A +	src/about_tracing/tracing_ui_client_test.js	View	3 chunks	+51 lines, -3 lines	0 comments	Download
M	trace_viewer.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

haraken

This is the about_tracing part change of https://codereview.appspot.com/39310043/ PTAL.

11 years, 5 months ago (2014-01-09 07:26:01 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r1087.

Expand All Messages | Collapse All Messages