code review 4953048: src/cmd/5g/*: Adjustments for compilation with Plan 9 t...

src/cmd/5g/*: Adjustments for compilation with Plan 9 tool chain.

5g/cgen.c:
. USED(n4) as it is only mentioned in unreachable code later;
. dropped unused assignments;
. commented out unreachable code;
5g/cgen64.c:
5g/ggen.c:
. dropped unused assignments of function return value;
5g/gg.h:
. added varargck pragmas;
5g/peep.c:
. USED(p1) used only in unreacheable code;
. commented out unreachable code;
5g/reg.c:
. dropped unused assignment;

[lucio, 2011-08-26 21:15:49]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
rsc@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-08-26 21:25:18]

http://codereview.appspot.com/4953048/diff/4001/src/cmd/5g/peep.c
File src/cmd/5g/peep.c (right):

http://codereview.appspot.com/4953048/diff/4001/src/cmd/5g/peep.c#newcode48
src/cmd/5g/peep.c:48: Prog *p, *p1 = 0;
init after decls.
so below:

p1 = nil;
USED(p1);

http://codereview.appspot.com/4953048/diff/4001/src/cmd/5g/peep.c#newcode135
src/cmd/5g/peep.c:135: #ifdef	NOTDEF
please move this down after the return,
so that the reason for the #ifdef NOTDEF 
is clearer.

[lucio, 2011-08-26 21:39:55]

On Fri, Aug 26, 2011 at 11:25 PM, <rsc@golang.org> wrote:

>
>
http://codereview.appspot.com/**4953048/diff/4001/src/cmd/5g/**peep.c<http://...
> File src/cmd/5g/peep.c (right):
>
> http://codereview.appspot.com/**4953048/diff/4001/src/cmd/5g/**
>
peep.c#newcode48<http://codereview.appspot.com/4953048/diff/4001/src/cmd/5g/peep.c#newcode48>
> src/cmd/5g/peep.c:48: Prog *p, *p1 = 0;
> init after decls.
> so below:
>
> p1 = nil;
> USED(p1);
>
> Done


> http://codereview.appspot.com/**4953048/diff/4001/src/cmd/5g/**
>
peep.c#newcode135<http://codereview.appspot.com/4953048/diff/4001/src/cmd/5g/peep.c#newcode135>
> src/cmd/5g/peep.c:135: #ifdef   NOTDEF
> please move this down after the return,
> so that the reason for the #ifdef NOTDEF
> is clearer.
>
> Except that the return is redundant.  Should I not just drop it?

Lucio..



>
>
http://codereview.appspot.com/**4953048/<http://codereview.appspot.com/4953048/>
>

[rsc, 2011-08-26 21:41:19]

> Except that the return is redundant.  Should I not just drop it?

the return makes it clear that the function is over
and that's why the #ifdef NOTDEF is there.
without it i have to keep reading quite a long block
of code to find the #endif to see what happens
after the dead block.

please move it up above the #ifdef.
thanks.

[lucio, 2011-08-26 22:36:38]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[lucio, 2011-08-27 16:46:57]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-08-29 13:03:28]

LGTM

[rsc, 2011-08-29 13:34:58]

*** Submitted as http://code.google.com/p/go/source/detail?r=804d28c1d921 ***

5g: fix build on Plan 9

5g/cgen.c:
. USED(n4) as it is only mentioned in unreachable code later;
. dropped unused assignments;
. commented out unreachable code;
5g/cgen64.c:
5g/ggen.c:
. dropped unused assignments of function return value;
5g/gg.h:
. added varargck pragmas;
5g/peep.c:
. USED(p1) used only in unreacheable code;
. commented out unreachable code;
5g/reg.c:
. dropped unused assignment;

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4953048

Committer: Russ Cox <rsc@golang.org>