code review 4942050: go/build: add test support & use in gotest

go/build: add test support & use in gotest

A side-effect is that, just like foo_386.go
is only built on 386, foo_386_test.go is only
built for testing on 386.

[rsc, 2011-08-23 17:22:27]

Hello adg, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2011-08-23 22:32:43]

gotest changes LGTM
others seem reasonable; leaving for adg

[adg, 2011-08-24 00:22:11]

LGTM

http://codereview.appspot.com/4942050/diff/4/src/pkg/go/build/build_test.go
File src/pkg/go/build/build_test.go (right):

http://codereview.appspot.com/4942050/diff/4/src/pkg/go/build/build_test.go#n...
src/pkg/go/build/build_test.go:94: // XXX Why is this deferred?
There was a reason, but I can't remember what it was now. Maybe it's no longer
necessary. Drop it if the tests still pass without it.

http://codereview.appspot.com/4942050/diff/4/src/pkg/go/build/dir.go
File src/pkg/go/build/dir.go (right):

http://codereview.appspot.com/4942050/diff/4/src/pkg/go/build/dir.go#newcode24
src/pkg/go/build/dir.go:24: // Later: GOPATH
// TODO(rsc,adg): GOPATH

http://codereview.appspot.com/4942050/diff/4/src/pkg/go/build/dir.go#newcode50
src/pkg/go/build/dir.go:50: TestGoFiles  []string // .go files in package
"_test.go files" ?

http://codereview.appspot.com/4942050/diff/4/src/pkg/go/build/dir.go#newcode204
src/pkg/go/build/dir.go:204: knownOS = make(map[string]bool)
isn't this make'ing it twice?

[mattn, 2011-08-24 00:41:03]

http://codereview.appspot.com/4942050/diff/4/src/pkg/go/build/build_test.go
File src/pkg/go/build/build_test.go (right):

http://codereview.appspot.com/4942050/diff/4/src/pkg/go/build/build_test.go#n...
src/pkg/go/build/build_test.go:31: TestGoFiles: 
sortstr([]string{"sqrt_test.go", "sqrt_" + runtime.GOARCH + "_test.go"}),
This won't match as expected because the files does not exist.

[rsc, 2011-08-24 02:40:26]

> This won't match as expected because the files does not exist.

thanks, added to the CL

[rsc, 2011-08-24 02:45:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=59231dccb894 ***

go/build: add test support & use in gotest

A side-effect is that, just like foo_386.go
is only built on 386, foo_386_test.go is only
built for testing on 386.

R=adg, r, mattn.jp
CC=golang-dev
http://codereview.appspot.com/4942050