Issue 49340043: No auth worker for local provider

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49340043: No auth worker for local provider (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by wallyworld

Modified:
11 years, 3 months ago

Reviewers:
mp+200931, thumper

Visibility:
Public.

Description

No auth worker for local provider The authentication worker does not work on the local provider as there is no ubuntu user. This branch do not start the worker for the local provider. https://code.launchpad.net/~wallyworld/juju-core/auth-worker-local-provider/+merge/200931 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : No auth worker for local provider #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/jujud/machine.go	View	1	1 chunk	+8 lines, -3 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

thumper

https://codereview.appspot.com/49340043/diff/1/cmd/jujud/machine.go File cmd/jujud/machine.go (right): https://codereview.appspot.com/49340043/diff/1/cmd/jujud/machine.go#newcode178 cmd/jujud/machine.go:178: if providerType != provider.Local && providerType != provider.Null { ...

11 years, 3 months ago (2014-01-08 23:13:00 UTC) #2

thumper

LGTM https://codereview.appspot.com/49340043/diff/20001/cmd/jujud/machine.go File cmd/jujud/machine.go (right): https://codereview.appspot.com/49340043/diff/20001/cmd/jujud/machine.go#newcode178 cmd/jujud/machine.go:178: if providerType != provider.Local || entity.Tag() != names.MachineTag(bootstrapMachineId) ...

11 years, 3 months ago (2014-01-09 03:13:35 UTC) #4

wallyworld

11 years, 3 months ago (2014-01-09 03:26:12 UTC) #5

https://codereview.appspot.com/49340043/diff/20001/cmd/jujud/machine.go
File cmd/jujud/machine.go (right):

https://codereview.appspot.com/49340043/diff/20001/cmd/jujud/machine.go#newco...
cmd/jujud/machine.go:178: if providerType != provider.Local || entity.Tag() !=
names.MachineTag(bootstrapMachineId) {
On 2014/01/09 03:13:35, thumper wrote:
> a.MachineId != bootstrapMachineId 
> 
> would also work.

Done.

Expand All Messages | Collapse All Messages