Issue 4932044: code review 4932044: effective_go: fix brace quotes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4932044: code review 4932044: effective_go: fix brace quotes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by r

Modified:
13 years, 6 months ago

Reviewers:

CC:
golang-dev, dsymonds

Visibility:
Public.

Patch Set 2 : diff -r c85e630263ae https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c85e630263ae https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 81604923c9b8 https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	doc/effective_go.html	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	doc/effective_go.tmpl	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2011-08-21 08:18:51 UTC) #1

dsymonds

What about something like this in the .tmpl file? <code>{{html "{{if .}}"}}</code>

13 years, 6 months ago (2011-08-21 09:25:38 UTC) #2

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 6 months ago (2011-08-21 13:47:52 UTC) #3

dsymonds

LGTM http://codereview.appspot.com/4932044/diff/6001/doc/effective_go.tmpl File doc/effective_go.tmpl (right): http://codereview.appspot.com/4932044/diff/6001/doc/effective_go.tmpl#newcode2948 doc/effective_go.tmpl:2948: The piece from the <code>{{html "{{if .}}"}}</code> actually, ...

13 years, 6 months ago (2011-08-21 22:16:45 UTC) #4

13 years, 6 months ago (2011-08-21 22:18:12 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=c82245bd848b ***

effective_go: fix brace quotes.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/4932044

Expand All Messages | Collapse All Messages