Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(838)

Issue 4918047: Correct baud rates for AIS and compass as defaults

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by grund(helms-)mann
Modified:
11 years ago
Reviewers:
rekwall, bsuter
CC:
avalonsailing_googlegroups.com
Base URL:
http://avalonsailing.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M io/aiscat_main.c View 2 chunks +2 lines, -2 lines 0 comments Download
M io/compasscat_main.c View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
grund(helms-)mann
14 years, 4 months ago (2011-08-23 08:42:26 UTC) #1
rekwall
14 years, 4 months ago (2011-08-23 08:48:28 UTC) #2
LGTM

Den 23 augusti 2011 10:42 skrev <grundmann@google.com>:

> Reviewers: bsuter, rekwall,
>
>
>
> Please review this at
http://codereview.appspot.com/**4918047/<http://codereview.appspot.com/4918047/>
>
> Affected files:
>  M     io/aiscat_main.c
>  M     io/compasscat_main.c
>
>
> Index: io/compasscat_main.c
> ==============================**==============================**=======
> --- io/compasscat_main.c        (revision 262)
> +++ io/compasscat_main.c        (working copy)
> @@ -60,7 +60,7 @@
>   fprintf(stderr,
>           "usage: %s [options] /dev/ttyXX\n"
>           "options:\n"
> -          "\t-b baudrate         (default unchanged)\n"
> +          "\t-b baudrate         (default 19200)\n"
>           "\t-d debug            (don't syslog, -dd is open serial as plain
> file)\n"
>           , argv0);
>   exit(2);
> @@ -127,7 +127,7 @@
>  int main(int argc, char* argv[]) {
>
>   int ch;
> -  int baudrate = 0;
> +  int baudrate = 19200;  //  19200, 8, 1, N
>
>   argv0 = strrchr(argv[0], '/');
>   if (argv0) ++argv0; else argv0 = argv[0];
> Index: io/aiscat_main.c
> ==============================**==============================**=======
> --- io/aiscat_main.c    (revision 262)
> +++ io/aiscat_main.c    (working copy)
> @@ -53,7 +53,7 @@
>        fprintf(stderr,
>                "usage: %s [options] [/dev/ttyXX]\n"
>                "options:\n"
> -               "\t-b baudrate         (default unchanged)\n"
> +               "\t-b baudrate         (default 38400)\n"
>                "\t-d debug            (don't syslog, -dd opens port as
> plain file)\n"
>                "will read NMEA sentence from stdin with no arguments.\n"
>                , argv0);
> @@ -102,7 +102,7 @@
>  int main(int argc, char* argv[]) {
>
>        int ch;
> -       int baudrate = 0;
> +       int baudrate = 38400;
>
>        argv0 = strrchr(argv[0], '/');
>        if (argv0) ++argv0; else argv0 = argv[0];
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b