Issue 49060: Template Library support for Shindig Java

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 49060: Template Library support for Shindig Java

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by levik

Modified:
11 years, 1 month ago

Reviewers:
opensocial.evan, shindig.remailer, awiner

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+425 lines, -85 lines)			Patch
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java	View	8 chunks	+71 lines, -17 lines	0 comments	Download
A	java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/AbstractTagRegistry.java	View	1 chunk	+32 lines, -0 lines	0 comments	Download
A	java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/CompositeTagRegistry.java	View	1 chunk	+41 lines, -0 lines	0 comments	Download
A	java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTagRegistry.java	View	1 chunk	+52 lines, -0 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TagRegistry.java	View	1 chunk	+6 lines, -58 lines	0 comments	Download
A	java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateLibrary.java	View	1 chunk	+135 lines, -0 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java	View	2 chunks	+16 lines, -4 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/RenderTagHandlerTest.java	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/TemplateBasedTagHandlerTest.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/TemplateLibraryTest.java	View	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

awiner

16 years, 9 months ago (2009-04-24 02:18:32 UTC) #1

Looks good.  I'll clean up some of the details - e.g., don't use
getElementsByTagName(), which descends into children, and add some caching of
parse results and support for <JavaScript> and <Style> elements.

Expand All Messages | Collapse All Messages