Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(193)

Issue 4904045: code review 4904045: godoc: show all top-level decls for (fake) package builtin (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by gri
Modified:
13 years, 7 months ago
Reviewers:
CC:
r, adg, golang-dev
Visibility:
Public.

Description

godoc: show all top-level decls for (fake) package builtin

Patch Set 1 #

Patch Set 2 : diff -r 25e954ab474b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M src/cmd/godoc/godoc.go View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5
gri
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-08-16 01:43:05 UTC) #1
r
LGTM for now we should suppress the package clause, perhaps in the next CL
13 years, 7 months ago (2011-08-16 01:48:26 UTC) #2
adg
It could be more general. Instead of "package builtin", we could use "package documentation" and ...
13 years, 7 months ago (2011-08-16 01:59:32 UTC) #3
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=a6bbe1b3fb7d *** godoc: show all top-level decls for (fake) package builtin R=r, ...
13 years, 7 months ago (2011-08-16 02:05:59 UTC) #4
gri
13 years, 7 months ago (2011-08-16 02:07:03 UTC) #5
Perhaps a more general mechanism is warranted in another CL. I'll
think a bit about it.
- Robert

On Mon, Aug 15, 2011 at 6:59 PM, Andrew Gerrand <adg@golang.org> wrote:
> It could be more general.
>
> Instead of "package builtin", we could use "package documentation" and
> make that the special case. Then it could be used by authors of other
> libraries.
>
> Andrew
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b