Issue 4894057: code review 4894057: type switches: test for pathological case

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4894057: code review 4894057: type switches: test for pathological case (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by gri

Modified:
13 years, 8 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

type switches: test for pathological case

Patch Set 2 : diff -r 233a0938ac15 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 233a0938ac15 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 233a0938ac15 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 5 : diff -r dab583e3969f https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	test/typeswitch2.go	View	1 2 3 4	1 chunk	+19 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-08-18 19:06:13 UTC) #1

http://codereview.appspot.com/4894057/diff/7001/test/typeswitch2.go File test/typeswitch2.go (right): http://codereview.appspot.com/4894057/diff/7001/test/typeswitch2.go#newcode37 test/typeswitch2.go:37: // The first t is in a different scope ...

13 years, 8 months ago (2011-08-19 03:42:20 UTC) #2

gri

13 years, 8 months ago (2011-08-19 16:31:54 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=443be59de1ba ***

type switches: test for pathological case

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/4894057

Expand All Messages | Collapse All Messages