Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(193)

Issue 4894047: Fix build dependencies. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by Siggi
Modified:
6 years, 2 months ago
Reviewers:
chrisha, rogerm
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix build dependencies. Make common_lib expose a hard dependency instead of syzygy_version doing so. Turns out that hard_dependency from a "none" target does not seem to propagate to a lib target. Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk399

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M syzygy/common/common.gyp View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 3
Siggi
6 years, 2 months ago (2011-08-15 21:30:27 UTC) #1
chrisha
lgtm with typo http://codereview.appspot.com/4894047/diff/1/syzygy/common/common.gyp File syzygy/common/common.gyp (right): http://codereview.appspot.com/4894047/diff/1/syzygy/common/common.gyp#newcode94 syzygy/common/common.gyp:94: # files that from syzygy_version that ...
6 years, 2 months ago (2011-08-15 21:31:20 UTC) #2
rogerm
6 years, 2 months ago (2011-08-16 13:43:54 UTC) #3
lgtm

On 15 August 2011 17:31, <chrisha@chromium.org> wrote:

> lgtm with typo
>
>
>
http://codereview.appspot.com/**4894047/diff/1/syzygy/common/**common.gyp<htt...
> File syzygy/common/common.gyp (right):
>
> http://codereview.appspot.com/**4894047/diff/1/syzygy/common/**
>
common.gyp#newcode94<http://codereview.appspot.com/4894047/diff/1/syzygy/common/common.gyp#newcode94>
> syzygy/common/common.gyp:94: # files that from syzygy_version that are
> included in compiles.
> that from?
>
>
>
http://codereview.appspot.com/**4894047/<http://codereview.appspot.com/4894047/>
>
> --
> You received this message because you are subscribed to the Google Groups
> "sawbuck-changes" group.
> To post to this group, send email to
sawbuck-changes@googlegroups.**com<sawbuck-changes@googlegroups.com>
> .
> To unsubscribe from this group, send email to sawbuck-changes+unsubscribe@
> **googlegroups.com <sawbuck-changes%2Bunsubscribe@googlegroups.com>.
> For more options, visit this group at http://groups.google.com/**
>
group/sawbuck-changes?hl=en<http://groups.google.com/group/sawbuck-changes?hl=en>
> .
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted