Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(458)

Issue 4890041: code review 4890041: godoc: fix escaping in templates (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by gri
Modified:
13 years, 7 months ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

godoc: fix escaping in templates - HTML-escape URL paths - URL-escape URL parameters

Patch Set 1 #

Patch Set 2 : diff -r de51e6f7dd3e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r de51e6f7dd3e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 27c59a10a156 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 034e5f3c30b7 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M lib/godoc/codewalkdir.html View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M lib/godoc/dirlist.html View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M lib/godoc/search.html View 1 2 3 5 chunks +13 lines, -12 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
gri
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-08-13 00:17:20 UTC) #1
bradfitz
LGTM It all reads correctly with escaping of the right type in the right places, ...
13 years, 7 months ago (2011-08-13 00:35:22 UTC) #2
gri
13 years, 7 months ago (2011-08-15 22:15:57 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=8a9fcd3d510f ***

godoc: fix escaping in templates

- HTML-escape URL paths
- URL-escape URL parameters

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/4890041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b