code review 4889043: rpc: implement ServeRequest to synchronously serve a si...

rpc: implement ServeRequest to synchronously serve a single request.

This is useful for applications that want to micromanage the rpc service.
Moved part of ServeCodec into a new readRequest function.
Renamed existing readRequest to readRequestHeader, and reordered
its parameters to align with the new readRequest and service.call.

[ssougou, 2011-08-13 00:31:30]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
msolomon@google.com, sougou@google.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-08-13 09:35:10]

looks good but we need a test of the new function

[ssougou, 2011-08-13 15:10:09]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com, msolomon@google.com, sougou@google.com),

Please take another look.

[sougou, 2011-08-13 15:14:14]

Unfortunately, the test is longer than the lines changed, but I couldn't
think of anything simpler.

On Sat, Aug 13, 2011 at 8:10 AM, <ssougou@gmail.com> wrote:

> Hello golang-dev@googlegroups.com, r@golang.org (cc:
>
> golang-dev@googlegroups.com, msolomon@google.com, sougou@google.com),
>
> Please take another look.
>
>
>
>
http://codereview.appspot.com/**4889043/<http://codereview.appspot.com/4889043/>
>

[r, 2011-08-15 03:43:43]

http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server_test.go
File src/pkg/rpc/server_test.go (right):

http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server_test.go#ne...
src/pkg/rpc/server_test.go:270: // Can be used to test ServeSingle()
s/()/./

[rsc, 2011-08-15 16:11:09]

lg
leaving for r

http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server.go
File src/pkg/rpc/server.go (right):

http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server.go#newcode417
src/pkg/rpc/server.go:417: // ServeSingle is like ServeCodec but synchronously
serves a single request
suggest ServeRequest instead of ServeSingle.

// ServeRequest serves one request from codec and then returns.
// It does not close the codec.

the part about goroutines is not strictly
relevant: what's relevant is when it returns.

http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server.go#newcode593
src/pkg/rpc/server.go:593: // ServeSingle is like ServeCodec but synchronously
serves a single request
same

[ssougou, 2011-08-15 20:15:39]

Hello golang-dev@googlegroups.com, r@golang.org, rsc@golang.org (cc:
golang-dev@googlegroups.com, msolomon@google.com, sougou@google.com),

Please take another look.

[sougou, 2011-08-15 20:17:17]

http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server.go
File src/pkg/rpc/server.go (right):

http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server.go#newcode417
src/pkg/rpc/server.go:417: // ServeSingle is like ServeCodec but synchronously
serves a single request
On 2011/08/15 16:11:09, rsc wrote:
> suggest ServeRequest instead of ServeSingle.
> 
> // ServeRequest serves one request from codec and then returns.
> // It does not close the codec.
> 
> the part about goroutines is not strictly
> relevant: what's relevant is when it returns.

Done.

http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server.go#newcode593
src/pkg/rpc/server.go:593: // ServeSingle is like ServeCodec but synchronously
serves a single request
On 2011/08/15 16:11:09, rsc wrote:
> same

Done.

http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server_test.go
File src/pkg/rpc/server_test.go (right):

http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server_test.go#ne...
src/pkg/rpc/server_test.go:270: // Can be used to test ServeSingle()
On 2011/08/15 03:43:43, r wrote:
> s/()/./

Done.

[r, 2011-08-15 22:02:29]

LGTM

[r, 2011-08-15 22:06:29]

*** Submitted as http://code.google.com/p/go/source/detail?r=034e5f3c30b7 ***

rpc: implement ServeRequest to synchronously serve a single request.

This is useful for applications that want to micromanage the rpc service.
Moved part of ServeCodec into a new readRequest function.
Renamed existing readRequest to readRequestHeader, and reordered
its parameters to align with the new readRequest and service.call.

R=golang-dev, r, rsc, sougou
CC=golang-dev, msolomon
http://codereview.appspot.com/4889043

Committer: Rob Pike <r@golang.org>