Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(460)

Issue 4889043: code review 4889043: rpc: implement ServeRequest to synchronously serve a si... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by ssougou
Modified:
13 years, 7 months ago
Reviewers:
CC:
golang-dev, r, rsc, sougou, msolomon
Visibility:
Public.

Description

rpc: implement ServeRequest to synchronously serve a single request. This is useful for applications that want to micromanage the rpc service. Moved part of ServeCodec into a new readRequest function. Renamed existing readRequest to readRequestHeader, and reordered its parameters to align with the new readRequest and service.call.

Patch Set 1 #

Patch Set 2 : diff -r c7efe3448d1a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r de51e6f7dd3e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r de51e6f7dd3e https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 5 : diff -r 27f839c9fae4 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -34 lines) Patch
M src/pkg/rpc/server.go View 1 2 3 4 5 chunks +59 lines, -31 lines 0 comments Download
M src/pkg/rpc/server_test.go View 1 2 3 4 4 chunks +84 lines, -3 lines 0 comments Download

Messages

Total messages: 10
ssougou
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, msolomon@google.com, sougou@google.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-08-13 00:31:30 UTC) #1
r
looks good but we need a test of the new function
13 years, 7 months ago (2011-08-13 09:35:10 UTC) #2
ssougou
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com, msolomon@google.com, sougou@google.com), Please take another look.
13 years, 7 months ago (2011-08-13 15:10:09 UTC) #3
sougou
Unfortunately, the test is longer than the lines changed, but I couldn't think of anything ...
13 years, 7 months ago (2011-08-13 15:14:14 UTC) #4
r
http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server_test.go File src/pkg/rpc/server_test.go (right): http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server_test.go#newcode270 src/pkg/rpc/server_test.go:270: // Can be used to test ServeSingle() s/()/./
13 years, 7 months ago (2011-08-15 03:43:43 UTC) #5
rsc
lg leaving for r http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server.go File src/pkg/rpc/server.go (right): http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server.go#newcode417 src/pkg/rpc/server.go:417: // ServeSingle is like ServeCodec ...
13 years, 7 months ago (2011-08-15 16:11:09 UTC) #6
ssougou
Hello golang-dev@googlegroups.com, r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com, msolomon@google.com, sougou@google.com), Please take another look.
13 years, 7 months ago (2011-08-15 20:15:39 UTC) #7
sougou
http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server.go File src/pkg/rpc/server.go (right): http://codereview.appspot.com/4889043/diff/8001/src/pkg/rpc/server.go#newcode417 src/pkg/rpc/server.go:417: // ServeSingle is like ServeCodec but synchronously serves a ...
13 years, 7 months ago (2011-08-15 20:17:17 UTC) #8
r
LGTM
13 years, 7 months ago (2011-08-15 22:02:29 UTC) #9
r
13 years, 7 months ago (2011-08-15 22:06:29 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=034e5f3c30b7 ***

rpc: implement ServeRequest to synchronously serve a single request.

This is useful for applications that want to micromanage the rpc service.
Moved part of ServeCodec into a new readRequest function.
Renamed existing readRequest to readRequestHeader, and reordered
its parameters to align with the new readRequest and service.call.

R=golang-dev, r, rsc, sougou
CC=golang-dev, msolomon
http://codereview.appspot.com/4889043

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b