Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 4877041: Fixes footnote automatic numbering. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by MikeSol
Modified:
7 years, 10 months ago
Reviewers:
mike, dak, reinhold, mail, Graham Percival, Reinhold, pkx166h, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fixes footnote automatic numbering.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Gets numbering right. #

Patch Set 3 : Update for issue 1791 #

Patch Set 4 : Correct fix for number order (issue 1791). #

Patch Set 5 : Weeds out dead footnote grobs to prevent segfault (issue 1791). #

Patch Set 6 : Rebase against current master. #

Total comments: 3

Patch Set 7 : Turns footnote_grobs_ into a grob array. #

Total comments: 1

Patch Set 8 : Still memory problems, but cleaner code that's hopefully easier to read. #

Patch Set 9 : Removes unnecessary function call. #

Total comments: 3

Patch Set 10 : Should not break regtests (and should work to boot!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -43 lines) Patch
M lily/footnote-engraver.cc View 1 2 3 4 5 6 7 3 chunks +8 lines, -0 lines 0 comments Download
M lily/grob.cc View 1 2 3 4 5 6 7 8 9 2 chunks +18 lines, -0 lines 0 comments Download
M lily/include/grob.hh View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M lily/include/system.hh View 1 2 3 4 5 6 7 2 chunks +3 lines, -5 lines 0 comments Download
M lily/page-layout-problem.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M lily/span-bar-engraver.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M lily/system.cc View 1 2 3 4 5 6 7 8 9 9 chunks +85 lines, -34 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 28
MikeSol
This gets the numbering of automatic footnotes correct for systems with more than one staff. ...
8 years, 1 month ago (2011-08-11 13:52:49 UTC) #1
Reinhold
Regtest missing. Much better now, but with my example there are still some inconsistencies. In ...
8 years, 1 month ago (2011-08-11 14:48:42 UTC) #2
mike_apollinemike.com
On Aug 11, 2011, at 4:48 PM, reinhold.kainhofer@gmail.com wrote: > Regtest missing. > > Much ...
8 years, 1 month ago (2011-08-11 15:10:23 UTC) #3
MikeSol
Hey Reinhold et al, This newest patch set should do the trick for automatic numbering. ...
7 years, 11 months ago (2011-10-04 06:30:24 UTC) #4
pkx166h
Passes make but fails make check. Cannot see where I just get --snip-- job 0 ...
7 years, 11 months ago (2011-10-04 06:48:56 UTC) #5
mike_apollinemike.com
On Oct 4, 2011, at 8:48 AM, pkx166h@gmail.com wrote: > Passes make but fails make ...
7 years, 11 months ago (2011-10-04 06:50:31 UTC) #6
pkx166h
Passes make and make check looks ok, I get something on page ../regression/page-turn-page-breaking.log and I'm ...
7 years, 11 months ago (2011-10-05 06:58:06 UTC) #7
mike_apollinemike.com
On Oct 5, 2011, at 8:58 AM, pkx166h@gmail.com wrote: > Passes make and make check ...
7 years, 11 months ago (2011-10-05 07:10:09 UTC) #8
pkx166h
Hello, (still) getting --snip-- @ -4,6 +4,8 @@ Preprocessing graphical objects... Calculating page and line ...
7 years, 11 months ago (2011-10-14 07:30:11 UTC) #9
mike_apollinemike.com
On Oct 14, 2011, at 9:30 AM, pkx166h@gmail.com wrote: > Hello, (still) getting > > ...
7 years, 11 months ago (2011-10-14 10:41:21 UTC) #10
hanwenn
http://codereview.appspot.com/4877041/diff/17001/lily/system.cc File lily/system.cc (left): http://codereview.appspot.com/4877041/diff/17001/lily/system.cc#oldcode321 lily/system.cc:321: return &footnote_grobs_; I think you can do this more ...
7 years, 11 months ago (2011-10-15 21:41:20 UTC) #11
mike_apollinemike.com
On Oct 15, 2011, at 11:41 PM, hanwenn@gmail.com wrote: > > http://codereview.appspot.com/4877041/diff/17001/lily/system.cc > File lily/system.cc ...
7 years, 11 months ago (2011-10-16 10:06:13 UTC) #12
Graham Percival
On Sun, Oct 16, 2011 at 12:06:05PM +0200, mike@apollinemike.com wrote: > On Oct 15, 2011, ...
7 years, 11 months ago (2011-10-16 16:20:15 UTC) #13
mail_philholmes.net
----- Original Message ----- From: "Graham Percival" <graham@percival-music.ca> To: <mike@apollinemike.com> Cc: <reply@codereview.appspotmail.com>; <mtsolo@gmail.com>; <reinhold.kainhofer@gmail.com>; <lilypond-devel@gnu.org>; ...
7 years, 11 months ago (2011-10-16 17:21:34 UTC) #14
dak
http://codereview.appspot.com/4877041/diff/25001/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/4877041/diff/25001/lily/grob.cc#newcode639 lily/grob.cc:639: if (!vag) How is vag supposed to have become ...
7 years, 10 months ago (2011-11-10 05:00:43 UTC) #15
pkx166h
See http://code.google.com/p/lilypond/issues/detail?id=1791#c10 Patch fails make check James
7 years, 10 months ago (2011-11-10 07:11:18 UTC) #16
pkx166h
Passes make but fails make check see: http://code.google.com/p/lilypond/issues/detail?id=1791#c13 James
7 years, 10 months ago (2011-11-14 11:05:44 UTC) #17
mike_apollinemike.com
On Nov 14, 2011, at 12:05 PM, pkx166h@gmail.com wrote: > Passes make but fails make ...
7 years, 10 months ago (2011-11-14 11:13:59 UTC) #18
dak
http://codereview.appspot.com/4877041/diff/26012/lily/system.cc File lily/system.cc (right): http://codereview.appspot.com/4877041/diff/26012/lily/system.cc#newcode248 lily/system.cc:248: if (s->original ()) You don't check for success of ...
7 years, 10 months ago (2011-11-14 11:34:24 UTC) #19
dak
lily/grobarray.cc contains the following: SCM Grob_array::mark_smob (SCM s) { (void) s; #if 0 /* see ...
7 years, 10 months ago (2011-11-14 11:43:11 UTC) #20
mike_apollinemike.com
Thanks for the feedback! A couple questions below. On Nov 14, 2011, at 12:34 PM, ...
7 years, 10 months ago (2011-11-14 13:23:18 UTC) #21
mike_apollinemike.com
On Nov 14, 2011, at 12:43 PM, dak@gnu.org wrote: > lily/grobarray.cc contains the following: > ...
7 years, 10 months ago (2011-11-14 13:25:05 UTC) #22
dak
"mike@apollinemike.com" <mike@apollinemike.com> writes: > Thanks for the feedback! A couple questions below. > > On ...
7 years, 10 months ago (2011-11-14 13:31:52 UTC) #23
reinhold_fam.tuwien.ac.at
On 2011-11-14 14:24, mike@apollinemike.com wrote: > Reinhold - how did you do the memory profiling ...
7 years, 10 months ago (2011-11-14 13:32:51 UTC) #24
mike_apollinemike.com
On Nov 14, 2011, at 2:32 PM, Reinhold Kainhofer wrote: > On 2011-11-14 14:24, mike@apollinemike.com ...
7 years, 10 months ago (2011-11-14 14:59:04 UTC) #25
Graham Percival
On Thu, Nov 17, 2011 at 08:57:26AM +0100, mike@apollinemike.com wrote: > Of course, it'd be ...
7 years, 10 months ago (2011-11-17 22:11:59 UTC) #26
mike_apollinemike.com
On Nov 14, 2011, at 3:58 PM, mike@apollinemike.com wrote: > Some more info. > With ...
7 years, 10 months ago (2011-11-17 22:34:41 UTC) #27
mike_apollinemike.com
7 years, 10 months ago (2011-11-18 16:37:46 UTC) #28
On Nov 17, 2011, at 1:05 PM, Graham Percival wrote:

> On Thu, Nov 17, 2011 at 08:57:26AM +0100, mike@apollinemike.com wrote:
>> Of course, it'd be great if during the compilation stage some
>> tool could do a scan for all get/set property/object calls in
>> LilyPond (in .ly, .scm, and .cc documents) and crash the
>> compilation if called properties lack interfaces and/or
>> docstrings.  This seems like a separate (and less pressing)
>> issue from the memleak, however.
> 
> I wouldn't be surprised if some of the warnings from gcc and/or
> clang and/or valgrind point to such a problem.  Of course,
> actually cleaning up all those warnings in all those programs
> could take anywhere from 10 to 100 hours -- such a task is likely
> to involve a lot of plumbing in the dark and wishfully-forgotten
> parts of lilypond (notably stuff in flower/ ).  It would be great
> if somebody wanted to undertake such archeology, though.
> 
> - Graham

As part of the solution, I've put together a patch that does documenting of some
undocumented objects.  I'll post this in the not-too-distant future.

Here are all of the explicitly referenced properties and objects that I could
find that have no documentation.  Not surprisingly, most of them are for Probs,
which for some reason are not documented at all (is this Prob-lematic?).

PROBS
foot-stencil
first-markup-line
bottom-space
last-markup-line
system-grob
footnotes
lines
number
head-stencil
penalty
last-in-score
configuration
tight-spacing
staff-refpoint-extent
is-title

GROBS
ties
forced-spacing
melody-spanner
note-collision

MUSIC
class
context
id
events
moment
property-path
ops
music-cause

Cheers,
MS

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b