Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1323)

Issue 4875050: code review 4875050: builtin: tweak a couple of descriptions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by r
Modified:
13 years, 7 months ago
Reviewers:
r2, dvyukov
CC:
golang-dev, adg, dsymonds
Visibility:
Public.

Description

builtin: tweak a couple of descriptions.

Patch Set 1 #

Patch Set 2 : diff -r a6bbe1b3fb7d https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r a6bbe1b3fb7d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/pkg/builtin/builtin.go View 1 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-08-16 05:04:38 UTC) #1
r
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 7 months ago (2011-08-16 05:17:35 UTC) #2
adg
LGTM
13 years, 7 months ago (2011-08-16 05:21:11 UTC) #3
dsymonds
LGTM
13 years, 7 months ago (2011-08-16 05:23:32 UTC) #4
r
*** Submitted as http://code.google.com/p/go/source/detail?r=83b22ae0f3e8 *** builtin: tweak a couple of descriptions. R=golang-dev, adg, dsymonds CC=golang-dev ...
13 years, 7 months ago (2011-08-16 05:24:07 UTC) #5
dvyukov
LGTM http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go#newcode110 src/pkg/builtin/builtin.go:110: // clauses involving c will never execute. I ...
13 years, 7 months ago (2011-08-16 05:26:30 UTC) #6
r2
On Aug 16, 2011, at 3:26 PM, dvyukov@google.com wrote: > LGTM > > > http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go ...
13 years, 7 months ago (2011-08-16 05:27:24 UTC) #7
dvyukov
13 years, 7 months ago (2011-08-16 05:38:19 UTC) #8
On 2011/08/16 05:27:24, r2 wrote:
> On Aug 16, 2011, at 3:26 PM, mailto:dvyukov@google.com wrote:
> 
> > LGTM
> > 
> > 
> > http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go
> > File src/pkg/builtin/builtin.go (right):
> > 
> >
>
http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go#ne...
> > src/pkg/builtin/builtin.go:110: // clauses involving c will never
> > execute.
> > I want to turn your attention to select part again, documentation must
> > be consistent with implementation one way or another.
> 
> Please explain the problem better.

It does not work as specified currently:

package main
func main() {
        c := make(chan int)
        close(c)
        select {
        case _,_ = <-c: println("RECV")
        default: println("DEFAULT")
        }
}

$ 6g tst.go && 6l tst.6 && ./6.out
RECV
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b