code review 4875050: builtin: tweak a couple of descriptions.

builtin: tweak a couple of descriptions.

[r, 2011-08-16 05:04:38]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-08-16 05:17:35]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-08-16 05:21:11]

LGTM

[dsymonds, 2011-08-16 05:23:32]

LGTM

[r, 2011-08-16 05:24:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=83b22ae0f3e8 ***

builtin: tweak a couple of descriptions.

R=golang-dev, adg, dsymonds
CC=golang-dev
http://codereview.appspot.com/4875050

[dvyukov, 2011-08-16 05:26:30]

LGTM

http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go
File src/pkg/builtin/builtin.go (right):

http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go#ne...
src/pkg/builtin/builtin.go:110: // clauses involving c will never execute.
I want to turn your attention to select part again, documentation must be
consistent with implementation one way or another.

[r2, 2011-08-16 05:27:24]

On Aug 16, 2011, at 3:26 PM, dvyukov@google.com wrote:

> LGTM
> 
> 
> http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go
> File src/pkg/builtin/builtin.go (right):
> 
>
http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go#ne...
> src/pkg/builtin/builtin.go:110: // clauses involving c will never
> execute.
> I want to turn your attention to select part again, documentation must
> be consistent with implementation one way or another.

Please explain the problem better.

-rob

[dvyukov, 2011-08-16 05:38:19]

On 2011/08/16 05:27:24, r2 wrote:
> On Aug 16, 2011, at 3:26 PM, mailto:dvyukov@google.com wrote:
> 
> > LGTM
> > 
> > 
> > http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go
> > File src/pkg/builtin/builtin.go (right):
> > 
> >
>
http://codereview.appspot.com/4875050/diff/2001/src/pkg/builtin/builtin.go#ne...
> > src/pkg/builtin/builtin.go:110: // clauses involving c will never
> > execute.
> > I want to turn your attention to select part again, documentation must
> > be consistent with implementation one way or another.
> 
> Please explain the problem better.

It does not work as specified currently:

package main
func main() {
        c := make(chan int)
        close(c)
        select {
        case _,_ = <-c: println("RECV")
        default: println("DEFAULT")
        }
}

$ 6g tst.go && 6l tst.6 && ./6.out
RECV