Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 4873045: code review 4873045: godoc: fix lib/godoc/packake.txt template (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by gri
Modified:
13 years, 7 months ago
Reviewers:
CC:
r, adg, golang-dev
Visibility:
Public.

Description

godoc: fix lib/godoc/package.txt template - show documentation in text mode; e.g.: http://localhost:7777/cmd/godoc/?f=text - simplify template by using $ variable

Patch Set 1 #

Patch Set 2 : diff -r de51e6f7dd3e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r de51e6f7dd3e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8a9fcd3d510f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 8a9fcd3d510f https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 8a9fcd3d510f https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 8a9fcd3d510f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M lib/godoc/package.txt View 1 4 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 6
gri
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-08-12 23:54:19 UTC) #1
gri
Hello r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 7 months ago (2011-08-15 22:18:16 UTC) #2
adg
> godoc: fix lib/godoc/packake.txt template To fix that typo you'll need to hg change and ...
13 years, 7 months ago (2011-08-15 22:22:37 UTC) #3
gri
PTAL. Fixed CL text. The actual fix is in the template. - gri On Mon, ...
13 years, 7 months ago (2011-08-15 22:25:07 UTC) #4
adg
LGTM
13 years, 7 months ago (2011-08-15 22:38:20 UTC) #5
gri
13 years, 7 months ago (2011-08-15 22:42:30 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=25e954ab474b ***

godoc: fix lib/godoc/package.txt template

- show documentation in text mode; e.g.:
http://localhost:7777/cmd/godoc/?f=text

- simplify template by using $ variable

R=r, adg
CC=golang-dev
http://codereview.appspot.com/4873045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b