Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 4854046: update youtube-jsonc-sample (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by yanivi
Modified:
14 years, 2 months ago
Reviewers:
rmistry
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : minor fixes based on feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -377 lines) Patch
M picasa-atom-oauth-sample/.settings/org.eclipse.jdt.ui.prefs View 1 chunk +117 lines, -363 lines 0 comments Download
M youtube-jsonc-sample/instructions.html View 1 1 chunk +1 line, -1 line 0 comments Download
M youtube-jsonc-sample/pom.xml View 1 4 chunks +31 lines, -8 lines 0 comments Download
M youtube-jsonc-sample/src/com/google/api/client/sample/youtube/Feed.java View 1 chunk +1 line, -0 lines 0 comments Download
M youtube-jsonc-sample/src/com/google/api/client/sample/youtube/YouTubeClient.java View 2 chunks +2 lines, -3 lines 0 comments Download
M youtube-jsonc-sample/src/com/google/api/client/sample/youtube/YouTubeSample.java View 1 chunk +1 line, -1 line 0 comments Download
M youtube-jsonc-sample/src/com/google/api/client/sample/youtube/YouTubeUrl.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
yanivi
14 years, 2 months ago (2011-08-08 21:18:20 UTC) #1
rmistry
LGTM http://codereview.appspot.com/4854046/diff/1/picasa-atom-oauth-sample/.settings/org.eclipse.jdt.ui.prefs File picasa-atom-oauth-sample/.settings/org.eclipse.jdt.ui.prefs (right): http://codereview.appspot.com/4854046/diff/1/picasa-atom-oauth-sample/.settings/org.eclipse.jdt.ui.prefs#newcode1 picasa-atom-oauth-sample/.settings/org.eclipse.jdt.ui.prefs:1: #Wed Mar 30 13:22:28 EDT 2011 Did you ...
14 years, 2 months ago (2011-08-08 22:00:40 UTC) #2
yanivi
14 years, 2 months ago (2011-08-08 23:41:52 UTC) #3
committing now...

http://codereview.appspot.com/4854046/diff/1/picasa-atom-oauth-sample/.settin...
File picasa-atom-oauth-sample/.settings/org.eclipse.jdt.ui.prefs (right):

http://codereview.appspot.com/4854046/diff/1/picasa-atom-oauth-sample/.settin...
picasa-atom-oauth-sample/.settings/org.eclipse.jdt.ui.prefs:1: #Wed Mar 30
13:22:28 EDT 2011
On 2011/08/08 22:00:40, rmistry wrote:
> Did you mean to have this file in this CL?

It was meant to be in the next CS, but I figured why not already take care of it
now.

http://codereview.appspot.com/4854046/diff/1/youtube-jsonc-sample/pom.xml
File youtube-jsonc-sample/pom.xml (right):

http://codereview.appspot.com/4854046/diff/1/youtube-jsonc-sample/pom.xml#new...
youtube-jsonc-sample/pom.xml:12: <name>Example for the YouTube API using
JSON-C</name>
On 2011/08/08 22:00:40, rmistry wrote:
> nit: Period after JSON-C.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b