Issue 4844054: Updating books-v1-json-cmdline-sample to use the new generated library based on 1.5

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -266 lines)			Patch
M	chrome-licensing-json-oauth-sample/.classpath	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome-licensing-json-oauth-sample/instructions.html	View	1 2 3 4 5 6 7 8 9 10	3 chunks	+3 lines, -3 lines	0 comments	Download
A	chrome-licensing-json-oauth-sample/logging.properties	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome-licensing-json-oauth-sample/pom.xml	View	1 2 3 4 5 6 7 8 9 10	4 chunks	+74 lines, -11 lines	0 comments	Download
R	chrome-licensing-json-oauth-sample/src/com/google/api/client/sample/chrome/licensing/ChromeLicensingSample.java	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -90 lines	0 comments	Download
R	chrome-licensing-json-oauth-sample/src/com/google/api/client/sample/chrome/licensing/model/ChromeLicensingUrl.java	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -40 lines	0 comments	Download
R	chrome-licensing-json-oauth-sample/src/com/google/api/client/sample/chrome/licensing/model/ClientCredentials.java	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -33 lines	0 comments	Download
R	chrome-licensing-json-oauth-sample/src/com/google/api/client/sample/chrome/licensing/model/Debug.java	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -54 lines	0 comments	Download
R	chrome-licensing-json-oauth-sample/src/com/google/api/client/sample/chrome/licensing/model/License.java	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -31 lines	0 comments	Download
A	chrome-licensing-json-oauth-sample/src/main/java/com/google/api/services/samples/chrome/licensing/cmdline/ChromeLicensingSample.java	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+89 lines, -0 lines	0 comments	Download
A	chrome-licensing-json-oauth-sample/src/main/java/com/google/api/services/samples/chrome/licensing/cmdline/ClientCredentials.java	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

yanivi

http://codereview.appspot.com/4844054/diff/6001/books-cmdline-sample/com/google/api/client/sample/books/BooksSample.java File books-cmdline-sample/com/google/api/client/sample/books/BooksSample.java (left): http://codereview.appspot.com/4844054/diff/6001/books-cmdline-sample/com/google/api/client/sample/books/BooksSample.java#oldcode59 books-cmdline-sample/com/google/api/client/sample/books/BooksSample.java:59: if (API_KEY != null && API_KEY.length() > 0) { ...

14 years, 2 months ago (2011-08-09 13:53:31 UTC) #2

yanivi

Please update to the latest generated snapshot jars: http://code.google.com/p/google-api-java-client/source/browse/com/google/apis/google-api-services-books/v1-1.2.0-beta-SNAPSHOT/google-api-services-books-v1-1.2.0-beta-SNAPSHOT.pom?repo=mavenrepo

14 years, 2 months ago (2011-08-09 15:49:14 UTC) #3

rmistry

I updated pom.xml to use the new generated snapshot jars with: <dependency> <groupId>com.google.apis</groupId> <artifactId>google-api-services-books</artifactId> <version>v1-1.2.0-beta-SNAPSHOT</version> ...

14 years, 2 months ago (2011-08-09 16:13:13 UTC) #4

I updated pom.xml to use the new generated snapshot jars with:

<dependency>
  <groupId>com.google.apis</groupId>
  <artifactId>google-api-services-books</artifactId>
  <version>v1-1.2.0-beta-SNAPSHOT</version>
</dependency>

as opposed to:

<dependency>	
  <groupId>com.google.api.services.books</groupId>	
  <artifactId>google-api-services-books-v1</artifactId>	
  <version>1.2.0-beta-SNAPSHOT</version>	
</dependency>

But setKey still gives a compilation error in BooksSample.java

http://codereview.appspot.com/4844054/diff/6001/books-cmdline-sample/com/goog...
File books-cmdline-sample/com/google/api/client/sample/books/BooksSample.java
(left):

http://codereview.appspot.com/4844054/diff/6001/books-cmdline-sample/com/goog...
books-cmdline-sample/com/google/api/client/sample/books/BooksSample.java:59: if
(API_KEY != null && API_KEY.length() > 0) {
On 2011/08/09 13:53:32, yanivi wrote:
> don't need the if-statement, just always set it

Done.

http://codereview.appspot.com/4844054/diff/6001/books-cmdline-sample/com/goog...
File books-cmdline-sample/com/google/api/client/sample/books/BooksSample.java
(right):

http://codereview.appspot.com/4844054/diff/6001/books-cmdline-sample/com/goog...
books-cmdline-sample/com/google/api/client/sample/books/BooksSample.java:15:
package com.google.api.client.sample.books;
On 2011/08/09 13:53:32, yanivi wrote:
> for consistency please rename package to
> com.google.api.services.samples.books.cmdline

Done.

http://codereview.appspot.com/4844054/diff/6001/books-cmdline-sample/com/goog...
books-cmdline-sample/com/google/api/client/sample/books/BooksSample.java:60:
books.setApiKey(API_KEY);
On 2011/08/09 13:53:32, yanivi wrote:
> use setKey instead

Done.

http://codereview.appspot.com/4844054/diff/6001/books-cmdline-sample/com/goog...
books-cmdline-sample/com/google/api/client/sample/books/BooksSample.java:174: if
(!e.getResponse().getContentType().equals(Json.CONTENT_TYPE)) {
On 2011/08/09 13:53:32, yanivi wrote:
> to handle the rare case of getContentType() == null, better to write it as if
> (!Json.CONTENT_TYPE.equals(...

Done.

yanivi

http://codereview.appspot.com/4844054/diff/8003/books-cmdline-sample/.classpath File books-cmdline-sample/.classpath (right): http://codereview.appspot.com/4844054/diff/8003/books-cmdline-sample/.classpath#newcode3 books-cmdline-sample/.classpath:3: <classpathentry kind="src" path="."/> the convention in Maven is that ...

14 years, 2 months ago (2011-08-09 20:13:46 UTC) #6

rmistry

14 years, 2 months ago (2011-08-09 20:48:39 UTC) #7

LGTM

Congrats on your first sample! :)

Expand All Messages | Collapse All Messages

Issue 4844054: Updating books-v1-json-cmdline-sample to use the new generated library based on 1.5 (Closed)

Patch Set 1 #

Patch Set 2 : Fixing whitespace. #

Patch Set 3 : Updating instructions.html #

Patch Set 4 : Removing unnecessary jetty dependency #

Patch Set 5 : Cleaned up #

Patch Set 6 : Addressing code review comments #

Patch Set 7 : Addressing code review comments II #

Patch Set 8 : Rename package to com.google.api.services.samples.books.cmdline #

Patch Set 9 : pom.xml changes #

Patch Set 10 : Addressing comments #

Patch Set 11 : inception year fix #

Messages