Issue 4844044: Have some ConfigInjectionProcessor fields overridable.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4844044: Have some ConfigInjectionProcessor fields overridable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by mhermanto

Modified:
14 years, 7 months ago

Reviewers:
johnfargo, fargo

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/js/ConfigInjectionProcessor.java	View		2 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

johnfargo

On 2011/08/03 21:36:04, johnfargo wrote: > On 2011/08/03 21:29:31, mhermanto wrote: > > LGTM++ (though ...

14 years, 7 months ago (2011-08-03 21:36:13 UTC) #3

mhermanto

14 years, 7 months ago (2011-08-03 21:38:12 UTC) #4

Correct.

On Wed, Aug 3, 2011 at 2:36 PM, <johnfargo@gmail.com> wrote:

> On 2011/08/03 21:36:04, johnfargo wrote:
>
>> On 2011/08/03 21:29:31, mhermanto wrote:
>>
>
>  LGTM++
>>
>
> (though they're not overridable, just usable in overrides :))
>
>
>
http://codereview.appspot.com/**4844044/<http://codereview.appspot.com/4844044/>
>

Expand All Messages | Collapse All Messages