Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 4839055: update picasa & docs samples (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by yanivi
Modified:
14 years, 2 months ago
Reviewers:
rmistry
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add docs sample #

Total comments: 4

Patch Set 3 : various updates #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+610 lines, -1181 lines) Patch
M buzz-cmdline-sample/instructions.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M buzz-cmdline-sample/pom.xml View 1 2 3 chunks +16 lines, -27 lines 0 comments Download
M buzz-cmdline-sample/src/main/java/com/google/api/services/samples/buzz/cmdline/ActivityActions.java View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M buzz-cmdline-sample/src/main/java/com/google/api/services/samples/buzz/cmdline/BuzzSample.java View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
A cmdline-sample-shared/findbugs-exclude.xml View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M cmdline-sample-shared/pom.xml View 1 2 4 chunks +13 lines, -11 lines 0 comments Download
M discovery-cmdline-sample/pom.xml View 1 2 3 chunks +16 lines, -25 lines 0 comments Download
M docs-cmdline-sample/.classpath View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M docs-cmdline-sample/.project View 1 2 1 chunk +1 line, -1 line 0 comments Download
M docs-cmdline-sample/.settings/org.eclipse.jdt.ui.prefs View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M docs-cmdline-sample/instructions.html View 1 2 3 chunks +24 lines, -8 lines 0 comments Download
A docs-cmdline-sample/logging.properties View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M docs-cmdline-sample/pom.xml View 1 2 3 chunks +45 lines, -17 lines 0 comments Download
A docs-cmdline-sample/src/main/java/com/google/api/services/samples/docs/cmdline/DocsClient.java View 1 2 1 chunk +106 lines, -0 lines 0 comments Download
M docs-cmdline-sample/src/main/java/com/google/api/services/samples/docs/cmdline/DocsSample.java View 1 2 2 chunks +24 lines, -50 lines 0 comments Download
M docs-cmdline-sample/src/main/java/com/google/api/services/samples/docs/cmdline/DocsUrl.java View 1 2 3 chunks +16 lines, -17 lines 0 comments Download
M docs-cmdline-sample/src/main/java/com/google/api/services/samples/docs/cmdline/DocumentListEntry.java View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M docs-cmdline-sample/src/main/java/com/google/api/services/samples/docs/cmdline/DocumentListFeed.java View 1 2 2 chunks +6 lines, -16 lines 0 comments Download
M docs-cmdline-sample/src/main/java/com/google/api/services/samples/docs/cmdline/Entry.java View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M docs-cmdline-sample/src/main/java/com/google/api/services/samples/docs/cmdline/Feed.java View 1 2 2 chunks +6 lines, -19 lines 0 comments Download
M docs-cmdline-sample/src/main/java/com/google/api/services/samples/docs/cmdline/Link.java View 1 2 1 chunk +9 lines, -11 lines 0 comments Download
R docs-v3-atom-oauth-sample/.settings/org.eclipse.jdt.core.prefs View 1 1 chunk +0 lines, -12 lines 0 comments Download
R docs-v3-atom-oauth-sample/src/com/google/api/client/sample/docs/v3/Auth.java View 1 1 chunk +0 lines, -117 lines 0 comments Download
R docs-v3-atom-oauth-sample/src/com/google/api/client/sample/docs/v3/LoginCallbackServer.java View 1 1 chunk +0 lines, -165 lines 0 comments Download
R docs-v3-atom-oauth-sample/src/com/google/api/client/sample/docs/v3/model/Debug.java View 1 1 chunk +0 lines, -54 lines 0 comments Download
R docs-v3-atom-oauth-sample/src/com/google/api/client/sample/docs/v3/model/Namespace.java View 1 1 chunk +0 lines, -42 lines 0 comments Download
R picasa-atom-oauth-sample/src/com/google/api/client/sample/picasa/model/Auth.java View 1 chunk +0 lines, -120 lines 0 comments Download
R picasa-atom-oauth-sample/src/com/google/api/client/sample/picasa/model/LoginCallbackServer.java View 1 chunk +0 lines, -159 lines 0 comments Download
R picasa-atom-oauth-sample/src/com/google/api/client/sample/picasa/model/Util.java View 1 chunk +0 lines, -54 lines 0 comments Download
M picasa-cmdline-sample/.classpath View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M picasa-cmdline-sample/.project View 1 2 1 chunk +1 line, -1 line 0 comments Download
M picasa-cmdline-sample/.settings/org.eclipse.jdt.core.prefs View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M picasa-cmdline-sample/.settings/org.eclipse.jdt.ui.prefs View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M picasa-cmdline-sample/instructions.html View 1 2 3 chunks +19 lines, -2 lines 0 comments Download
A picasa-cmdline-sample/logging.properties View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M picasa-cmdline-sample/pom.xml View 1 2 3 chunks +45 lines, -17 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/AlbumEntry.java View 1 2 1 chunk +9 lines, -11 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/AlbumFeed.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/Author.java View 1 2 2 chunks +10 lines, -12 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/Category.java View 1 2 2 chunks +10 lines, -12 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/Entry.java View 1 2 1 chunk +9 lines, -11 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/Feed.java View 1 2 1 chunk +9 lines, -11 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/Link.java View 1 2 1 chunk +9 lines, -11 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/MediaContent.java View 1 2 2 chunks +7 lines, -9 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/MediaGroup.java View 1 2 2 chunks +7 lines, -9 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/PhotoEntry.java View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/PicasaClient.java View 1 2 9 chunks +37 lines, -30 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/PicasaSample.java View 1 2 5 chunks +5 lines, -15 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/PicasaUrl.java View 1 2 3 chunks +15 lines, -16 lines 0 comments Download
M picasa-cmdline-sample/src/main/java/com/google/api/services/samples/picasa/cmdline/UserFeed.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M prediction-cmdline-sample/instructions.html View 1 2 4 chunks +22 lines, -12 lines 0 comments Download
A prediction-cmdline-sample/logging.properties View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M prediction-cmdline-sample/pom.xml View 1 2 4 chunks +23 lines, -26 lines 0 comments Download
M prediction-cmdline-sample/src/main/java/com/google/api/services/samples/prediction/cmdline/PredictionSample.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M youtube-jsonc-sample/.classpath View 1 2 1 chunk +1 line, -1 line 0 comments Download
M youtube-jsonc-sample/instructions.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M youtube-jsonc-sample/pom.xml View 1 2 3 chunks +12 lines, -3 lines 0 comments Download
M youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/Feed.java View 1 2 2 chunks +0 lines, -10 lines 2 comments Download
M youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/Item.java View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/Player.java View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/Video.java View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/VideoFeed.java View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/View.java View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/YouTubeClient.java View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/YouTubeSample.java View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/YouTubeUrl.java View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5
yanivi
14 years, 2 months ago (2011-08-09 00:23:10 UTC) #1
rmistry
http://codereview.appspot.com/4839055/diff/5001/docs-v3-atom-oauth-sample/instructions.html File docs-v3-atom-oauth-sample/instructions.html (right): http://codereview.appspot.com/4839055/diff/5001/docs-v3-atom-oauth-sample/instructions.html#newcode21 docs-v3-atom-oauth-sample/instructions.html:21: Similar to picasa-atom-oauth-sample/pom.xml: <p><b>Important:</b> after checking out the project, ...
14 years, 2 months ago (2011-08-09 16:51:31 UTC) #2
yanivi
Made some more changes. Please take a look again. http://codereview.appspot.com/4839055/diff/5001/docs-v3-atom-oauth-sample/instructions.html File docs-v3-atom-oauth-sample/instructions.html (right): http://codereview.appspot.com/4839055/diff/5001/docs-v3-atom-oauth-sample/instructions.html#newcode21 docs-v3-atom-oauth-sample/instructions.html:21: ...
14 years, 2 months ago (2011-08-09 17:47:51 UTC) #3
rmistry
LGTM http://codereview.appspot.com/4839055/diff/1002/youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/Feed.java File youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/Feed.java (left): http://codereview.appspot.com/4839055/diff/1002/youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/Feed.java#oldcode32 youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/Feed.java:32: int itemsPerPage; For my understanding: why are we ...
14 years, 2 months ago (2011-08-09 19:30:16 UTC) #4
yanivi
14 years, 2 months ago (2011-08-09 20:01:21 UTC) #5
http://codereview.appspot.com/4839055/diff/1002/youtube-jsonc-sample/src/main...
File
youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/Feed.java
(left):

http://codereview.appspot.com/4839055/diff/1002/youtube-jsonc-sample/src/main...
youtube-jsonc-sample/src/main/java/com/google/api/client/sample/youtube/Feed.java:32:
int itemsPerPage;
On 2011/08/09 19:30:16, rmistry wrote:
> For my understanding: why are we removing these vars?

Just because I'm not using them so I thought it would be nice to simplify the
sample a bit.  Not really important though.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b