LGTM On Thu, Aug 4, 2011 at 3:05 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 7 months ago
(2011-08-04 22:14:23 UTC)
#2
LGTM
On Thu, Aug 4, 2011 at 3:05 PM, <r@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> exp/norm: fix build by adding a test placeholder
>
> Please review this at
http://codereview.appspot.com/**4838050/<http://codereview.appspot.com/4838050/>
>
> Affected files:
> A src/pkg/exp/norm/norm_test.go
>
>
> Index: src/pkg/exp/norm/norm_test.go
> ==============================**==============================**=======
> new file mode 100644
> --- /dev/null
> +++ b/src/pkg/exp/norm/norm_test.**go
> @@ -0,0 +1,14 @@
> +// Copyright 2011 The Go Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package norm_test
> +
> +import (
> + "testing"
> +)
> +
> +func TestPlaceHolder(t *testing.T) {
> + // Does nothing, just allows the Makefile to be canonical
> + // while waiting for the package itself to be written.
> +}
>
>
>
Lgtm On Aug 4, 2011 6:05 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > > Message: ...
13 years, 7 months ago
(2011-08-04 22:20:59 UTC)
#3
Lgtm
On Aug 4, 2011 6:05 PM, <r@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> exp/norm: fix build by adding a test placeholder
>
> Please review this at http://codereview.appspot.com/4838050/
>
> Affected files:
> A src/pkg/exp/norm/norm_test.go
>
>
> Index: src/pkg/exp/norm/norm_test.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/src/pkg/exp/norm/norm_test.go
> @@ -0,0 +1,14 @@
> +// Copyright 2011 The Go Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package norm_test
> +
> +import (
> + "testing"
> +)
> +
> +func TestPlaceHolder(t *testing.T) {
> + // Does nothing, just allows the Makefile to be canonical
> + // while waiting for the package itself to be written.
> +}
>
>
*** Submitted as http://code.google.com/p/go/source/detail?r=5f932e0c8906 *** exp/norm: fix build by adding a test placeholder R=golang-dev, bradfitz, ...
13 years, 7 months ago
(2011-08-04 22:25:59 UTC)
#4
Issue 4838050: code review 4838050: exp/norm: fix build by adding a test placeholder
(Closed)
Created 13 years, 7 months ago by r
Modified 13 years, 7 months ago
Reviewers:
Base URL:
Comments: 0