code review 4832060: runtime: correct seh installation during callbacks

runtime: correct seh installation during callbacks

Every time we enter callback from Windows, it is
possible that go exception handler is not at the top
of per-thread exception handlers chain. So it needs
to be installed again. At this moment this is done
by replacing top SEH frame with SEH frame as at time
of syscall for the time of callback. This is incorrect,
because, if exception strike, we won't be able to call
any exception handlers installed inside syscall,
because they are not in the chain. This changes
procedure to add new SEH frame on top of existing
chain instead.

I also removed m sehframe field, because I don't
think it is needed. We use single global exception
handler everywhere.

[brainman, 2011-08-09 06:18:42]

Hello golang-dev@googlegroups.com (cc: hectorchu@gmail.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-08-10 06:06:23]

LGTM

http://codereview.appspot.com/4832060/diff/3001/src/pkg/runtime/runtime.h
File src/pkg/runtime/runtime.h (right):

http://codereview.appspot.com/4832060/diff/3001/src/pkg/runtime/runtime.h#new...
src/pkg/runtime/runtime.h:251: 
d

http://codereview.appspot.com/4832060/diff/3001/src/pkg/runtime/runtime.h#new...
src/pkg/runtime/runtime.h:255: 
d

[brainman, 2011-08-10 07:17:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=4ebeab48e11a ***

runtime: correct seh installation during callbacks

Every time we enter callback from Windows, it is
possible that go exception handler is not at the top
of per-thread exception handlers chain. So it needs
to be installed again. At this moment this is done
by replacing top SEH frame with SEH frame as at time
of syscall for the time of callback. This is incorrect,
because, if exception strike, we won't be able to call
any exception handlers installed inside syscall,
because they are not in the chain. This changes
procedure to add new SEH frame on top of existing
chain instead.

I also removed m sehframe field, because I don't
think it is needed. We use single global exception
handler everywhere.

R=golang-dev, r
CC=golang-dev, hectorchu
http://codereview.appspot.com/4832060

http://codereview.appspot.com/4832060/diff/3001/src/pkg/runtime/runtime.h
File src/pkg/runtime/runtime.h (right):

http://codereview.appspot.com/4832060/diff/3001/src/pkg/runtime/runtime.h#new...
src/pkg/runtime/runtime.h:251: 
On 2011/08/10 06:06:23, r wrote:
> d

Done.

http://codereview.appspot.com/4832060/diff/3001/src/pkg/runtime/runtime.h#new...
src/pkg/runtime/runtime.h:255: 
On 2011/08/10 06:06:23, r wrote:
> d

Done.