Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(753)

Issue 4830064: lily/auto-beam-engraver: keep a Context_handle to starting Staff (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by Keith
Modified:
8 years, 2 months ago
Reviewers:
pkx166h, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

lily/auto-beam-engraver: keep a Context_handle to starting Staff; issue 1800 The Context_handle is really a reference-counting pointer. It is used by the auto-change-iterator to keep the outlet Staff alive. Patch Set 1 gives two members more general names, because it makes sense to use Context_handle from the engraver side as well as the iterator side. Set 2, delta from Patch Set 1, shows the only functional change. Keeping the parent Staff of the beam alive, until the beam is complete, prevents the segfault of issue 1800.

Patch Set 1 : only renames function, variable #

Patch Set 2 : the important change, relative to Patch Set 2 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M lily/auto-beam-engraver.cc View 1 6 chunks +9 lines, -4 lines 1 comment Download
M lily/context.cc View 2 chunks +2 lines, -2 lines 1 comment Download
M lily/context-handle.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M lily/include/context.hh View 1 chunk +2 lines, -1 line 0 comments Download
M lily/include/context-handle.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/music-iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/part-combine-iterator.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M lily/quote-iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/tuplet-iterator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
pkx166h
Passes make and reg tests
8 years, 2 months ago (2011-08-06 21:36:27 UTC) #1
Neil Puttock
8 years, 2 months ago (2011-08-11 19:53:07 UTC) #2
LGTM.  Just needs a regtest.

http://codereview.appspot.com/4830064/diff/5001/lily/auto-beam-engraver.cc
File lily/auto-beam-engraver.cc (right):

http://codereview.appspot.com/4830064/diff/5001/lily/auto-beam-engraver.cc#ne...
lily/auto-beam-engraver.cc:85: Handle on the starting staff keeps it alive until
beam is comlete
complete

http://codereview.appspot.com/4830064/diff/5001/lily/context.cc
File lily/context.cc (right):

http://codereview.appspot.com/4830064/diff/5001/lily/context.cc#newcode38
lily/context.cc:38: return context_list_ == SCM_EOL && ! client_count_
!client_count_
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b