Issue 4830042: code review 4830042: build: handle spaces in $USER

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4830042: code review 4830042: build: handle spaces in $USER (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
arvindht

CC:
golang-dev, r

Visibility:
Public.

build: handle spaces in $USER Fixes issue 2107.

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -22 lines)			Patch
M	src/cmd/gotry/gotry	View	1 2	2 chunks	+7 lines, -6 lines	0 comments	Download
M	src/quietgcc.bash	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	test/run	View	1 2	4 chunks	+12 lines, -12 lines	0 comments	Download

Total messages: 5

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-28 16:52:00 UTC) #1

LGTM but have you tested it? i would like to go back in time, find ...

13 years, 7 months ago (2011-07-28 16:56:20 UTC) #2

rsc

On Thu, Jul 28, 2011 at 12:56, <r@golang.org> wrote: > LGTM but have you tested ...

13 years, 7 months ago (2011-07-28 17:01:39 UTC) #3

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=2313a84d4d4b *** build: handle spaces in $USER Fixes issue 2107. R=golang-dev, r ...

13 years, 7 months ago (2011-07-28 17:05:01 UTC) #4

arvindht

13 years, 7 months ago (2011-07-28 17:52:23 UTC) #5

>  # Write file to compile
> -rm -f /tmp/$USER.try.go
> +file="/tmp/$USER.try"
> +rm -f "file.go"

rm -f "$file.go"