code review 4826054: build: fix noclobber

build: fix noclobber

I got it backwards last time, and somehow
that was leaking into the parent shell?

[rsc, 2011-07-28 22:14:45]

Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-07-28 22:15:00]

can someone who knows bash look at this?

[iant2, 2011-07-28 23:07:15]

LGTM

Not sure about leaking into the parent shell, but "set -o noclobber"
turns on the noclobber flag and "set +o noclobber" turns it off.

Ian


rsc@golang.org writes:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> build: fix noclobber
>
> I got it backwards last time, and somehow
> that was leaking into the parent shell?
>
> Please review this at http://codereview.appspot.com/4826054/
>
> Affected files:
>   M src/env.bash
>
>
> Index: src/env.bash
> ===================================================================
> --- a/src/env.bash
> +++ b/src/env.bash
> @@ -89,9 +89,9 @@
>  fi
>
>  # Issue 2020: some users configure bash to default to
> -#	set +o noclobber
> +#	set -o noclobber
>  # which makes >x fail if x already exists.  Restore sanity.
> -set -o noclobber
> +set +o noclobber
>
>  # Tried to use . <($MAKE ...) here, but it cannot set environment
>  # variables in the version of bash that ships with OS X.  Amazing.

[rsc, 2011-07-28 23:38:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=ed3711631136 ***

build: fix noclobber

I got it backwards last time, and somehow
that was leaking into the parent shell?

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/4826054