Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 4826047: Dependency on http extensions android2 and android3; predictable version dependency (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by yanivi
Modified:
14 years, 4 months ago
Reviewers:
aiuto
Visibility:
Public.

Description

Add dependency on http extensions android2 and android3 so the built zip assembly has those jars in it. Revert back to specifying the HTTP project dependency explicitly. This brings back the predictability in behavior. It also ensures that if there is a built SNAPSHOT library, that it will still use the release library, not the snapshot. It also speeds up the process of computing the dependency, because if you specify a version range it requires a check to all repositories for an updated version.

Patch Set 1 #

Total comments: 5

Patch Set 2 : release.html updated; changes based on feedback #

Patch Set 3 : one more fix #

Patch Set 4 : another fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -72 lines) Patch
M google-oauth-client-assembly/assembly.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M google-oauth-client-assembly/pom.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pom.xml View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M release.html View 1 2 3 7 chunks +25 lines, -70 lines 0 comments Download

Messages

Total messages: 5
yanivi
14 years, 4 months ago (2011-07-27 20:57:00 UTC) #1
aiuto
http://codereview.appspot.com/4826047/diff/1/pom.xml File pom.xml (right): http://codereview.appspot.com/4826047/diff/1/pom.xml#newcode12 pom.xml:12: <version>1.5.0-beta-SNAPSHOT</version> Don't you want to move this out of ...
14 years, 4 months ago (2011-07-28 03:08:41 UTC) #2
yanivi
http://codereview.appspot.com/4826047/diff/1/pom.xml File pom.xml (right): http://codereview.appspot.com/4826047/diff/1/pom.xml#newcode12 pom.xml:12: <version>1.5.0-beta-SNAPSHOT</version> On 2011/07/28 03:08:41, aiuto wrote: > Don't you ...
14 years, 4 months ago (2011-07-28 12:58:32 UTC) #3
aiuto
lgtm http://codereview.appspot.com/4826047/diff/1/pom.xml File pom.xml (right): http://codereview.appspot.com/4826047/diff/1/pom.xml#newcode12 pom.xml:12: <version>1.5.0-beta-SNAPSHOT</version> On 2011/07/28 12:58:32, yanivi wrote: > On ...
14 years, 4 months ago (2011-07-28 13:44:34 UTC) #4
yanivi
14 years, 4 months ago (2011-07-28 14:54:18 UTC) #5
On 2011/07/28 13:44:34, aiuto wrote:
> lgtm
> 
> http://codereview.appspot.com/4826047/diff/1/pom.xml
> File pom.xml (right):
> 
> http://codereview.appspot.com/4826047/diff/1/pom.xml#newcode12
> pom.xml:12: <version>1.5.0-beta-SNAPSHOT</version>
> On 2011/07/28 12:58:32, yanivi wrote:
> > On 2011/07/28 03:08:41, aiuto wrote:
> > > Don't you want to move this out of SNAPSHOT too.
> > 
> > No.  This is done automatically by Maven as part of the release process.
> 
> OK. But huh? I can't believe they designed it backwards like that. Things
should
> be defined in terms of truth, and at push time we should be able to say if it
is
> a snapshot or release.

mvn release:prepare removes the -SNAPSHOT from the top-level <version> from the
pom.xml files, hg commits it and creates a 1.5.0-beta Hg tag.   

Clearly this is only appropriate for a non-snapshot release. I would need to
investigate if there is a way to modify the script to do a snapshot release. 
But let's continue that aspect of the discussion in a separate e-mail thread.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b