Issue 4826046: code review 4826046: gc: zero-width struct, zero-length array fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4826046: code review 4826046: gc: zero-width struct, zero-length array fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by rsc

Modified:
13 years, 7 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: zero-width struct, zero-length array fixes Fixes issue 1774. Fixes issue 2095. Fixes issue 2097.

Patch Set 1 #

Patch Set 2 : diff -r 051f7e8b1a7d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 051f7e8b1a7d https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -37 lines)			Patch
M	src/cmd/5g/cgen.c	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/cmd/5g/galign.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/6g/cgen.c	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/cmd/6g/galign.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8g/cgen.c	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download
M	src/cmd/8g/galign.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/align.c	View	1	5 chunks	+16 lines, -11 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/slice.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/bug273.go	View	1	3 chunks	+2 lines, -10 lines	0 comments	Download
A	test/fixedbugs/bug352.go	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-27 20:47:35 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=da40ff8d788e *** gc: zero-width struct, zero-length array fixes Fixes issue 1774. Fixes ...

13 years, 7 months ago (2011-07-27 20:47:52 UTC) #2

lgtm

Expand All Messages | Collapse All Messages