Issue 4825054: code review 4825054: unicode: fix case-mapping for roman numerals!!

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4825054: code review 4825054: unicode: fix case-mapping for roman numerals!! (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by r

Modified:
13 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

unicode: fix case-mapping for roman numerals!! Hurray! Also fix the mystical U+0345 COMBINING GREEK YPOGEGRAMMENI, so everyone is satisfied. Also add a -local flag to use local files for faster turnaround when debugging.

Patch Set 1 #

Patch Set 2 : diff -r 5fa47694f2c5 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -114 lines)			Patch
M	src/pkg/unicode/letter_test.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/unicode/maketables.go	View	9 chunks	+55 lines, -29 lines	0 comments	Download
M	src/pkg/unicode/tables.go	View	4 chunks	+6 lines, -85 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-27 22:49:35 UTC) #1

13 years, 7 months ago (2011-07-27 22:54:32 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c952e0304bf2 ***

unicode: fix case-mapping for roman numerals!!
Hurray!
Also fix the mystical U+0345 COMBINING GREEK YPOGEGRAMMENI,
so everyone is satisfied.
Also add a -local flag to use local files for faster turnaround
when debugging.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4825054

Expand All Messages | Collapse All Messages