Issue 4823057: code review 4823057: syscall: move bsd pipe syscall

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4823057: code review 4823057: syscall: move bsd pipe syscall (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by jsing

Modified:
13 years, 7 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

syscall: move bsd pipe syscall Not all BSDs have the same pipe() syscall implementation - move the Darwin/FreeBSD specific implementation into their respective OS syscall files. This will be needed to add OpenBSD syscall support.

Patch Set 1 #

Patch Set 2 : diff -r d34b31b7e93a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d34b31b7e93a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c0e0030f5308 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -10 lines)			Patch
M	src/pkg/syscall/syscall_bsd.go	View	1 2	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/pkg/syscall/syscall_darwin.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_freebsd.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jsing

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2011-07-29 13:44:18 UTC) #1

rsc

13 years, 7 months ago (2011-07-29 17:47:23 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=df07dd2282cf ***

syscall: move bsd pipe syscall

Not all BSDs have the same pipe() syscall implementation - move the
Darwin/FreeBSD specific implementation into their respective OS syscall files.
This will be needed to add OpenBSD syscall support.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4823057

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages