code review 4823056: exp/template: make Set.ParseFile etc resolve functions ...

exp/template: make Set.ParseFile etc resolve functions in the Set
Fixes issue 2114

[rog, 2011-07-28 16:06:48]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-07-28 16:53:53]

i'm ok with the fixes but not thrilled about the new not-in-Set helpers. it
seems to me if you're using those you're not building things correctly.

[r, 2011-07-28 16:58:33]

LGTM

[r, 2011-07-28 16:59:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=355408efced2 ***

exp/template: make Set.ParseFile etc resolve functions in the Set
Fixes issue 2114

R=r
CC=golang-dev
http://codereview.appspot.com/4823056

Committer: Rob Pike <r@golang.org>

[rog, 2011-07-28 17:02:19]

i wasn't thrilled either - i only added (e.g.) ParseFileInSet by
analogy with ParseFile.

i didn't want to restructure things too violently - feel free to
remove any or all of the new helpers.

On 28 July 2011 17:53,  <r@golang.org> wrote:
> i'm ok with the fixes but not thrilled about the new not-in-Set helpers.
> it seems to me if you're using those you're not building things
> correctly.
>
> http://codereview.appspot.com/4823056/
>

[rog, 2011-07-28 17:07:25]

BTW this needs a test. i couldn't quickly think of a way to fit it into
the existing framework, so i didn't do one, sorry.

On 28 July 2011 18:02, roger peppe <rogpeppe@gmail.com> wrote:
> i wasn't thrilled either - i only added (e.g.) ParseFileInSet by
> analogy with ParseFile.
>
> i didn't want to restructure things too violently - feel free to
> remove any or all of the new helpers.
>
> On 28 July 2011 17:53,  <r@golang.org> wrote:
>> i'm ok with the fixes but not thrilled about the new not-in-Set helpers.
>> it seems to me if you're using those you're not building things
>> correctly.
>>
>> http://codereview.appspot.com/4823056/
>>
>

[rsc, 2011-07-28 18:04:39]

it seems like Template.ParseFileInSet and Template.ParseInSet
should be unexported since they are just helpers for the Set methods.